Custom element loader#101
Closed
maier49 wants to merge 5 commits intodojo:masterfrom
Closed
Conversation
rorticus
approved these changes
Aug 24, 2020
matt-gadd
approved these changes
Sep 10, 2020
Member
|
Superseded by #108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes described in dojo/framework#770 and some additional test changes. Depends on dojo/framework#825 as well as dojo/webpack-contrib#295
There's also one (potentially significant) caveat with these. changes. The bootstrap file and all the dynamically loaded files for individual widgets will end up in the
distfolder the same way widget custom element scripts do now. However, when individual widget files are linked inindex.htmlthey are each copied over. Here only the bootstrap file is linked and so only it is copied over. The rest of the files (or the entire directory) for any widgets that might be loaded would need to be added to the externals configuration and copied over explicitly.