refactor(torii-args): bool values no need for explicit true

[Larkooo]

Summary by CodeRabbit

• Bug Fixes

  • Streamlined argument parsing for IndexingOptions and EventsOptions, enhancing clarity and reducing complexity.

• Refactor

  • Removed unnecessary attributes from boolean fields, simplifying their declarations while maintaining existing functionality.
  • Improved merging logic for command-line arguments and configuration file values in ToriiArgs, ensuring defaults are only updated when necessary.

[coderabbitai]

Walkthrough

Ohayo, sensei! The recent changes streamline the IndexingOptions and EventsOptions structs in the options.rs file by removing the action attribute from the pending and raw fields. This modification simplifies argument parsing, allowing these fields to default to their specified values without the need for explicit action settings. The overall structure of related options remains intact, with no new fields added or existing ones removed.

Changes

File Path	Change Summary
crates/torii/cli/src/options.rs	Removed action attribute from pending in IndexingOptions and raw in EventsOptions.
crates/torii/cli/src/args.rs	Updated with_config_file method and TryFrom implementation for ToriiArgs; streamlined merging logic for command-line and config values. Removed tests for events.raw and indexing.transactions.

Possibly related PRs

• fix: cli args for torii and katana with serde default #2692: This PR modifies the behavior of configuration files to allow for default values for unspecified fields, which relates to the changes in the main PR that simplify the argument parsing for IndexingOptions and EventsOptions.
• fix(torii): ensure correct serde of args in config file #2704: This PR ensures that serialized contracts within configuration files adhere to the expected format, which connects to the changes in the main PR that enhance the clarity and functionality of the IndexingOptions and EventsOptions structs.

Suggested reviewers

• glihm

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c0c2e39 and 5c1ad92.

📒 Files selected for processing (1)

• crates/torii/cli/src/args.rs (0 hunks)

💤 Files with no reviewable changes (1)

• crates/torii/cli/src/args.rs

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.51%. Comparing base (ffc9259) to head (5c1ad92).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2767   +/-   ##
=======================================
  Coverage   55.51%   55.51%           
=======================================
  Files         434      434           
  Lines       54295    54292    -3     
=======================================
- Hits        30140    30139    -1     
+ Misses      24155    24153    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.