Prepare release: v1.0.6 - #2801
Merged
Merged
Conversation
Contributor
WalkthroughOhayo, sensei! This pull request primarily updates the version numbers across several configuration files, specifically from Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
Cargo.lockis excluded by!**/*.lockcrates/dojo/core/Scarb.lockis excluded by!**/*.lockcrates/torii/types-test/Scarb.lockis excluded by!**/*.lockexamples/spawn-and-move/Scarb.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
Cargo.toml(1 hunks)crates/dojo/core/Scarb.toml(1 hunks)crates/torii/server/Cargo.toml(1 hunks)crates/torii/types-test/Scarb.toml(1 hunks)examples/spawn-and-move/Scarb.toml(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- examples/spawn-and-move/Scarb.toml
- Cargo.toml
- crates/dojo/core/Scarb.toml
- crates/torii/server/Cargo.toml
| edition = "2024_07" | ||
| name = "types_test" | ||
| version = "1.0.5" | ||
| version = "1.0.6" |
Contributor
There was a problem hiding this comment.
💡 Codebase verification
Ohayo sensei! Found some version inconsistencies that need attention!
The version update to 1.0.6 is not consistent across all packages. Here are the mismatched versions:
crates/dojo/core-cairo-test/Scarb.toml: version = "1.0.0-rc.0"crates/benches/contracts/Scarb.toml: version = "1.0.0-rc.0"examples/simple/Scarb.toml: version = "0.1.0"examples/game-lib/*/Scarb.toml: version = "0.1.0"crates/katana/contracts/Scarb.toml: version = "0.1.0"
While some packages might intentionally have different versions, the core packages should be aligned with the 1.0.6 release.
🔗 Analysis chain
Ohayo sensei! Version bump looks good!
The version update to 1.0.6 aligns with the release preparation.
Let's verify version consistency across all configuration files:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check version consistency across Scarb.toml and Cargo.toml files
echo "Checking Scarb.toml files..."
fd -e toml -x grep -l "version = " {} | while read -r file; do
echo "=== $file ==="
grep "version = " "$file"
done
echo -e "\nChecking Cargo.toml files..."
fd Cargo.toml -x grep -l "version = " {} | while read -r file; do
echo "=== $file ==="
grep "version = " "$file"
done
Length of output: 17405
glihm
approved these changes
Dec 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2801 +/- ##
==========================================
- Coverage 55.75% 55.74% -0.01%
==========================================
Files 439 439
Lines 55572 55572
==========================================
- Hits 30983 30978 -5
- Misses 24589 24594 +5 ☔ View full report in Codecov by Sentry. |
kariy
pushed a commit
that referenced
this pull request
Dec 13, 2024
Co-authored-by: glihm <glihm@users.noreply.github.com>
This was referenced Dec 16, 2024
This was referenced Dec 25, 2024
This was referenced Jan 2, 2025
This was referenced Jan 10, 2025
This was referenced Jan 14, 2025
This was referenced Jan 21, 2025
Merged
This was referenced Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
1.0.5to1.0.6, indicating a new release.Chores
Cargo.tomlfile for thetorii-serverpackage for better formatting.