feat: cover storage host directories in dokku_storage_entry - #440
Merged
josegonzalez merged 1 commit intoAug 9, 2026
Merged
Conversation
docket covers storage host directories exactly as far as `storage:create` reaches, so `dokku_storage_entry` gains the `annotations` and `labels` it was missing, validates its inputs offline against the same rules dokku enforces, and exports every attribute it can set rather than three of them. The `0o777` chmod and the `destroy_host_dir` removal that `ansible-dokku`'s `dokku_storage` does with raw filesystem calls stay in the wrapper, since dokku exposes no command for either and docket may be driving the host over SSH. A create-time option supplied alongside `state: absent` is now rejected rather than silently discarded.
josegonzalez
deleted the
416-decide-how-far-docket-covers-storage-host-directory-management
branch
August 9, 2026 04:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docket covers storage host directories exactly as far as
storage:createreaches, sodokku_storage_entrygains theannotationsandlabelsit was missing, validates its inputs offline against the same rules dokku enforces, and exports every attribute it can set rather than three of them. The0o777chmod and thedestroy_host_dirremoval thatansible-dokku'sdokku_storagedoes with raw filesystem calls stay in the wrapper, since dokku exposes no command for either and docket may be driving the host over SSH. A create-time option supplied alongsidestate: absentis now rejected rather than silently discarded.docs/ansible-dokku.mdrecords the decision as a per-option table under the module mapping, and host-directory management leaves the list of things a wrapper cannot delegate. The two pieces that stay behind are tracked in dokku/dokku#8913, and the fact thatchownapplies at create time only is tracked in #439.Closes #416.