fix: export the http-auth state of each app - #444
Merged
josegonzalez merged 1 commit intoAug 10, 2026
Merged
Conversation
`dokku_http_auth` advertised partial export support while implementing no exporter and appearing in no export order, so `docket export` silently dropped whether HTTP basic auth was serving on an app. It is now emitted after the rest of the http-auth family, because `http-auth:add-user`, `add-allowed-ip` and `add-domain` each turn auth on as a side effect and the task that owns the flag has to run last for the recipe's stated state to be the one that sticks. That also lets a disabled app whose users survived the disable export as `state: absent` rather than quietly coming back enabled. `state: present` no longer demands a username and password, matching the plugin, which takes them as optional trailing arguments and skips seeding a user without them. A new invariant test rules out the whole class by failing when a task claims to be exportable without being wired in, or is wired in while claiming it cannot be. The http-auth tasks now require dokku-http-auth 0.13.0.
josegonzalez
deleted the
428-dokku-http-auth-declares-export-support-but-is-never-exported
branch
August 10, 2026 03:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dokku_http_authadvertised partial export support while implementing no exporter and appearing in no export order, sodocket exportsilently dropped whether HTTP basic auth was serving on an app. It is now emitted after the rest of the http-auth family, becausehttp-auth:add-user,add-allowed-ipandadd-domaineach turn auth on as a side effect and the task that owns the flag has to run last for the recipe's stated state to be the one that sticks. That also lets a disabled app whose users survived the disable export asstate: absentrather than quietly coming back enabled.state: presentno longer demands a username and password, matching the plugin, which takes them as optional trailing arguments and skips seeding a user without them. A new invariant test rules out the whole class by failing when a task claims to be exportable without being wired in, or is wired in while claiming it cannot be. The http-auth tasks now require dokku-http-auth 0.13.0.The asymmetry that made the old ordering unworkable was fixed upstream in dokku/dokku-http-auth#40, released as 0.13.0, which is why the floor moves. Exporting the users as hashes rather than as required password inputs is tracked separately in #443.
Fixes #428