[Inagaki] Add GameAudio::GameSoundTable implementation - #70
Merged
Conversation
joakim-d
changed the title
Report for MarioClub_us (c17c5c3 - a43c9fb)📈 Matched code: 46.50% (+0.10%, +3100 bytes) ✅ 17 new matches
📉 1 regression in an unmatched item
|
joakim-d
force-pushed
the
reverse_gamesoundtable
branch
from
August 8, 2026 22:13
00792d7 to
7e6a16c
Compare
joakim-d
changed the title
joakim-d
marked this pull request as ready for review
August 8, 2026 22:18
joakim-d
force-pushed
the
reverse_gamesoundtable
branch
2 times, most recently
from
August 9, 2026 09:00
a7132c6 to
bd3e26b
Compare
Collaborator
|
Nice job! There are a few minor things that could probably be improved, but i suggest taking a look at Z2SoundInfo from Twilight Princess considering it looks like that was based of MKDD's audio library |
SwareJonge
reviewed
Aug 9, 2026
Comment on lines
+15
to
+23
| static inline bool isValid() { | ||
| bool resourceNotNull = false; | ||
| if(JASGlobalInstance<JAUSoundTable>::sInstance != NULL | ||
| && JASGlobalInstance<JAUSoundTable>::sInstance->getResource() != NULL) | ||
| { | ||
| resourceNotNull = true; | ||
| } | ||
| return resourceNotNull; | ||
| } |
Collaborator
There was a problem hiding this comment.
This chould be moved to the header and the temp value resourceNotNull probably isn't needed
Contributor
Author
There was a problem hiding this comment.
Done! I looked at TP implementation ;)
SwareJonge
reviewed
Aug 9, 2026
| #line 27 | ||
| JUT_ASSERT(isValid()); | ||
|
|
||
| JAUSoundTableItem* tableItem = JASGlobalInstance<JAUSoundTable>::sInstance->getData(soundID); |
Collaborator
There was a problem hiding this comment.
for every instance of JASGlobalInstance<JAUSoundTable>::sInstance use JASGlobalInstance<JAUSoundTable>::getInstance() instead
joakim-d
force-pushed
the
reverse_gamesoundtable
branch
from
August 9, 2026 17:55
bd3e26b to
a43c9fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GameAudio::GameSoundTable class implementation