Event type#18
Conversation
joelhoisko
left a comment
There was a problem hiding this comment.
Looks good to me, wrapping the old @artifact decorator with @eventType seems fine for me now, in the future we can think if we want to change our terminology and move away from artifact.
|
IMO we should not keep the |
|
I guess this also affects how much will the user be dealing with the artifact terminology while using the SDK in general (bit off topic for this PR) Will the user be making |
|
Artifacts is an internal terminology - developers don’t really work with these, they work with more concrete types like event types. From an SDK perspective, it does not add value to the developer having access to artifacts. While internally in the runtime, thats all we know |
|
That's a good clear up. I'll happily embrace that 😁 |
|
The changes made to this PR effectively made it a breaking change by removing the @artifact decorator. We should publish a new major version and deprecate these versions (4.1.0) on npm @joelhoisko |
Based of PR #17 Pull that in first
This introduces the new @eventtype decorator, which in fact is just an alias for the @artifact decorator. I think that having the @artifact decorator makes sense. And it makes sense that the registration of Artifacts is done the way that it's done now.