ci: add staticcheck and govulncheck to CI#71
Conversation
Closes dolph#30. Run staticcheck and govulncheck after go test -race in ci.yml.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6dd2800158
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| with: | ||
| version: latest | ||
|
|
||
| - uses: golang/govulncheck-action@v1 |
There was a problem hiding this comment.
When this step is left with no inputs, golang/govulncheck-action installs and scans with its default stable Go toolchain, while this workflow's earlier build/test and the release workflow both use go-version-file: go.mod (which is go 1.20). In any release built with the module-pinned toolchain, standard-library vulnerabilities that affect Go 1.20 can be missed because govulncheck is evaluating the latest stable stdlib instead of the one used for the binary; pass go-version-file: go.mod (and usually repo-checkout: false) so the vuln scan matches the artifact being shipped.
Useful? React with 👍 / 👎.
1 participant
Summary
Fixes #30. Adds staticcheck and govulncheck steps to the CI workflow after the existing vet/build/test jobs.
Test plan
go test ./...Made with Cursor