Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,9 @@ jobs:

- name: go test
run: go test -race ./...

- uses: dominikh/staticcheck-action@v1
with:
version: latest

- uses: golang/govulncheck-action@v1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Scan the same Go version that gets released

When this step is left with no inputs, golang/govulncheck-action installs and scans with its default stable Go toolchain, while this workflow's earlier build/test and the release workflow both use go-version-file: go.mod (which is go 1.20). In any release built with the module-pinned toolchain, standard-library vulnerabilities that affect Go 1.20 can be missed because govulncheck is evaluating the latest stable stdlib instead of the one used for the binary; pass go-version-file: go.mod (and usually repo-checkout: false) so the vuln scan matches the artifact being shipped.

Useful? React with 👍 / 👎.