Skip to content

HacksWidget: Merge tooltips for disabled settings into balloontips#14589

Merged
JosJuice merged 3 commits into
dolphin-emu:masterfrom
Dentomologist:merge_tooltips_for_disabled_settings_into_balloontips
Jun 28, 2026
Merged

HacksWidget: Merge tooltips for disabled settings into balloontips#14589
JosJuice merged 3 commits into
dolphin-emu:masterfrom
Dentomologist:merge_tooltips_for_disabled_settings_into_balloontips

Conversation

@Dentomologist

Copy link
Copy Markdown
Contributor

For Disable Bounding Box, merge the separate tooltip shown when the backend doesn't support Bounding Box into the normal tooltip.

For GPU Texture Decoding do the same thing, and also clarify when Arbitrary Mipmap Detection is currently disabling the setting.

Some images showing the GPU Texture Decoding changes:

master PR
GPU Texture Decoding not supported master_null PR_null
Arbitrary Mipmap Detection enabled master_arbitrary PR_arbitrary
Neither PR_available unchanged

Move function declarations before variable declarations.
Comment thread Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp Outdated
Comment thread Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp Outdated
Comment thread Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp Outdated

@mbc07 mbc07 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't even aware that separate hover tip was a thing when using the Null backend, and I'm all in for using our custom tooltips everywhere we can. Can't comment on code specifics, but I did some light testing on Windows and it works as expected, so LGTM...

When GPU Texture Decoding is disabled, explain why in the BalloonTip
instead of spawning a separate tooltip.
When a backend doesn't support BoundingBox, show that information in the
BalloonTip instead of spawning a separate tooltip.
@Dentomologist
Dentomologist force-pushed the merge_tooltips_for_disabled_settings_into_balloontips branch from 36d8ed8 to 518f5f4 Compare April 16, 2026 20:40
@JosJuice
JosJuice merged commit 8038496 into dolphin-emu:master Jun 28, 2026
13 checks passed
@Dentomologist
Dentomologist deleted the merge_tooltips_for_disabled_settings_into_balloontips branch June 28, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants