COPY TO support - #3140
Conversation
|
SummaryThe run covers core data export and import behavior across text, CSV, and binary formats, including special values, ordering, transactions, concurrent access, error recovery, and schema handling. It also exercises adversarial file-path and permission scenarios, revealing security boundary failures alongside a text-format round-trip compatibility issue. Not safe to merge yet — the PR introduces high-severity authorization and data-integrity risks because restricted users can write outside the approved export area and overwrite protected files, with an additional medium-severity text export/import failure. These are directly attributable merge blockers rather than unrelated observations. Tests run by ItoTip Reply with @itoqa to send us feedback on this test run. |
|
@zachmu DOLT
|
|
Diff SummaryThe run broadly covers data import and export across text, CSV, and binary formats, including typed values, NULLs, empty and Unicode content, ordering, chunk boundaries, malformed input, transaction recovery, session state, and option validation. Overall, normal flows and most adversarial cases behave correctly, with a gap in connection recovery after a malformed binary load. Merge with caution — the PR introduces a medium-severity failure in which malformed binary input can leave the connection unusable for subsequent work, making this a real recovery defect in changed behavior. Other medium-severity findings concern code outside this PR and are flag-for-later observations rather than merge drivers. Tests run by ItoTests that are no longer relevantBelow are tests that previously ran and are no longer relevant:
Additional Findings DetailsThese findings are unrelated to the current changes but were observed during testing. 🟡 Custom NULL markers are ignored
Evidence Package🟡 Duplicate format options are accepted
Evidence PackageTip Reply with @itoqa to send us feedback on this test run. |
|
|
Diff SummaryCoverage spans normal data import and export across text, CSV, and binary formats, including ordering, duplicate handling, session recovery, and protocol completion. It also exercises error paths and adversarial edge cases, with broad behavior passing but a gap where an export that never begins can still appear successful. Merge with caution — the PR introduces a medium-severity correctness issue that can produce false-positive export results when the expected data response is absent. Other exercised behavior is broadly healthy, but this verification failure should be addressed before relying on the replay results. Tests run by ItoFindings dismissed by reviewerBelow are prior failures a reviewer explicitly dismissed. They were not retested and are not counted as outstanding failures:
Tip Reply with @itoqa to send us feedback on this test run. |
fulghum
left a comment
There was a problem hiding this comment.
Looks good, just a few suggestions to look into. Ito has some interesting comments, too.
|
Diff SummaryThe run broadly covers data import and export across text, CSV, and binary formats, including null and empty values, escaping, chunked input, retries, cancellation, transaction behavior, and session recovery. It also exercises invalid or unsafe requests and adversarial malformed data, with most exercised behavior appearing healthy but a serious failed-import integrity issue remaining. Not safe to merge yet — this PR introduces a high-severity data-integrity defect where a failed binary file import can leave partial rows that later work may preserve or commit. The issue affects failure handling in a supported import path and is a merge blocker, while no unrelated failures are reported. Tests run by ItoTests that are no longer relevantBelow are tests that previously ran and are no longer relevant:
Tip Reply with @itoqa to send us feedback on this test run. |
|
Diff SummaryThe run covers database data import and export across text, CSV, and binary formats, including normal reads and writes, typed values, and round-trip preservation. It also exercises edge cases such as delimiters, escapes, multiline text, NULL versus empty values, and rejected server-file exports. Safe to merge — no failures or regressions attributable to this PR were found, and the exercised data-handling and safety behaviors remain healthy. There are no merge-blocking findings in this run. Tests run by Ito
Findings dismissed by reviewerBelow are prior failures a reviewer explicitly dismissed. They were not retested and are not counted as outstanding failures:
Tip Reply with @itoqa to send us feedback on this test run. |
|
Diff SummaryCoverage spans normal data loading and export flows across text, CSV, and binary formats, including typed values, nulls, empty fields, special characters, and round trips. It also exercises edge and failure handling such as malformed input, missing binary boundaries, rollback, connection recovery, chunked records, and exact preservation of text and binary data. Safe to merge — the exercised behavior is healthy across core flows and edge-case recovery, with no PR-attributable regressions or new failures. Previously passing checks were left untested or replaced by newer coverage, but nothing identified here is a merge blocker. Tests run by Ito
Tests that are no longer relevantBelow are tests that previously ran and are no longer relevant:
Tip Reply with @itoqa to send us feedback on this test run. |



Also adds support for the BINARY format of COPY FROM.
COPY TO FILE is not supported in light of security concerns. We will need to do some product design work to make this safe, similar to what's supported on the Dolt side.
Fixes #3086
Fixes #3085