Skip to content

Update expression plan strings - #3277

Open
zachmu wants to merge 12 commits into
mainfrom
zachmu/audit-expression-string
Open

Update expression plan strings#3277
zachmu wants to merge 12 commits into
mainfrom
zachmu/audit-expression-string

Conversation

@zachmu

@zachmu zachmu commented Sep 4, 2026

Copy link
Copy Markdown
Member

Updates plan expectations for dolthub/go-mysql-server#3803.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor
Main PR
Total 42090 42090
Successful 19625 19625
Failures 22465 22465
Partial Successes1 5440 5440
Main PR
Successful 46.6263% 46.6263%
Failures 53.3737% 53.3737%

${\color{red}Regressions (1)}$

subselect

QUERY:          select count(*) from tenk1 t
where (exists(select 1 from tenk1 k where k.unique1 = t.unique2) or ten < 0);
RECEIVED ERROR: timeout during Receive

${\color{lightgreen}Progressions (1)}$

window

QUERY: select ten,
  sum(unique1) + sum(unique2) as res,
  rank() over (order by sum(unique1) + sum(unique2)) as rank
from tenk1
group by ten order by ten;

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@coffeegoddd

coffeegoddd commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@zachmu DOLT

read_tests from_latency to_latency percent_change
covering_index_scan_postgres 2.43 2.43 0.0
groupby_scan_postgres 81.48 78.6 -3.53
index_join_postgres 2.35 2.26 -3.83
index_join_scan_postgres 1.64 1.61 -1.83
index_scan_postgres 475.79 467.3 -1.78
oltp_point_select 0.37 0.37 0.0
oltp_read_only 6.55 6.55 0.0
select_random_points 0.72 0.72 0.0
select_random_ranges 1.03 1.04 0.97
table_scan_postgres 475.79 475.79 0.0
types_table_scan_postgres 1191.92 1191.92 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert_postgres 6.67 6.67 0.0
oltp_insert 3.36 3.36 0.0
oltp_read_write 13.46 13.46 0.0
oltp_update_index 3.62 3.62 0.0
oltp_update_non_index 3.3 3.3 0.0
oltp_write_only 7.04 7.04 0.0
types_delete_insert_postgres 7.17 7.17 0.0

@itoqa

itoqa Bot commented Sep 4, 2026

Copy link
Copy Markdown

Ito QA test results
Commit: 5ccf07c: 9 test cases ran, 9 passed ✅.

Summary

Coverage spans core database behavior for constraints, indexes, schema-qualified lookups, counts, range queries, query-plan consistency, prepared-query reuse, and type conversion, including boundary and repeated-execution cases. Broader compatibility, dependency, and compilation checks also showed the change behaving cleanly across the affected areas.

Safe to merge — no regressions, new failures, or previously flagged failures were found, and the exercised database behavior and compatibility checks remain healthy.

Tests run by Ito

View full run

Result Severity Type Description
General The database returned the expected constraint records for tables and domains, including direct lookups, range searches, and query-plan checks.
General The index metadata, table lookup, and single-table and combined counts all matched the requested schema-qualified tables. The query plans also kept the expected count name and indexed access for both count forms.
General The database returned the expected plan for the constraint query. Both scalar range bounds were parenthesized correctly and the indexed catalog access stayed intact.
General The single-table and multi-table count queries returned the expected results, and both query plans used the same quoted count name through the projection, sort, grouping, and index steps.
Constraint The database returned the expected constraint records and indexed query plans. Direct lookups, scalar range searches, type filters, and text-to-OID conversion all passed.
Index The index metadata, table lookups, count results, and query plans all matched the expected values. The database endpoint is not a web page, so the browser connection error does not indicate a product failure.
Rev Prepared catalog queries returned the expected rows and counts on both executions. The returned index details and result types stayed consistent after the catalog lookup.
Rev The complete compatibility test suite finished successfully in 46.632 seconds. It reported no failures, panics, race-related errors, or unexpected changes outside the updated query-plan expectations.
Rev The pinned engine version resolved successfully, its checksums verified, and the affected testing, server, and command packages compiled without changing dependency files.

Tip

Reply with @itoqa to send us feedback on this test run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants