Handle omitted Act/365L reference end date - #259
Open
kadyrbekovhamit-cyber wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DayCount.year_frac()documentsdt3as optional for an ordinary two-date year-fraction calculation. In the annualACT_365Lbranch, however, a period that reaches a leap day compares that leap day withdt3even whendt3isNone. The call then raisesAttributeErrorinstead of returning a fraction.This change treats
dt2as the calculation-period end when no separate reference-period end is supplied. A caller that suppliesdt3for an accrued fraction keeps the existing reference-period behaviour.Reproducer
Before this change:
After this change:
The regression also distinguishes the ordinary two-date mode from an accrued-fraction call with an explicitly later coupon-period end, so the correction does not erase the existing
dt3semantics.Validation
python -m pytest unit_tests/test_FinDayCount.py -q: 11 passedpython -m pytest unit_tests -q: 959 passed, with four pre-existing LSMCRankWarningmessagesNonehandling reproduces the exception above.The example is synthetic. This PR makes no claim about a downstream system or financial loss.