Skip to content

v11.1.5: Response.css() no longer silently returns [] on errors

Choose a tag to compare

View all tags
@dondai1234 dondai1234 released this 21 Jul 11:44
v11.1.5
cff8c19

Fix: removed broad except Exception: return [] from Response.css(). Errors now propagate instead of being silently swallowed. Follow-up to #3.

The broad except was hiding:

  • ImportError when cssselect is missing (fixed in v11.1.4 by adding cssselect as dependency)
  • SelectorSyntaxError for invalid CSS selectors (now propagates so users know their selector is wrong)

The action layer validates CSS selectors upstream via validate_css_selector(), so invalid selectors are caught before reaching css().

805 tests (1 new: test_response_css_invalid_selector_raises).

Assets 2
Loading