fix: localize dates for all shipped languages (import moment locales)#147
Open
everysingletear wants to merge 1 commit into
Open
fix: localize dates for all shipped languages (import moment locales)#147everysingletear wants to merge 1 commit into
everysingletear wants to merge 1 commit into
Conversation
moment.locale(language) runs for the active language, but only moment/locale/ja was imported — so de/es/fr/nl/pt/zh-CN/ar fell back to English date formatting. Import each shipped locale statically, matching the existing ja import. Fixes donetick#142
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #142.
LocalizationContextcallsmoment.locale(language)for the active language, but onlymoment/locale/jawas imported — so moment silently fell back to English date formatting for de, es, fr, nl, pt, zh-CN, ar (onlyenandjawere localized).Change
Import each shipped locale statically in
src/i18n/config.js, matching the existingmoment/locale/jaline.Why static (not dynamic)
The issue raised static vs dynamic import. I went static because it matches the existing pattern, is trivially reviewable, and moment locale bundles are tiny (a few KB each). If you'd rather keep the main bundle leaner, I'm happy to switch to a dynamic
import()of just the active language's locale — just say the word.Testing
npm run buildpasses; all imported locale files resolve.Note:
ruis intentionally not included here — it comes with the Russian locale PR (#143).