Skip to content

v0.34.1 — The panel opens again

Choose a tag to compare

View all tags
@donkanishka donkanishka released this 01 Sep 00:23
· 36 commits to main since this release
v0.34.1
696deea
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.

A hotfix. 0.34.0 could not be opened at all — please update.

Fixed

  • The Font Manager control never appeared. The settings key list added in 0.34.0 was declared beside the functions that read it, several hundred lines below the state object that fingerprints the settings as it is built. var hoisting supplies the name but not the value, so the fingerprint read undefined, panel.js threw before it could register its Settings Bar control, and the plugin was unreachable from the builder. The list is now declared above the state it feeds.
  • CI could not have caught it. node --check parses a file and stops there, so it passed happily on a script that died on its first line of real work. tools/boot-check.js now boots the panel against a stubbed DOM and fails the build if it throws; run against 0.34.0 it reproduces the exact error.

Everything in 0.34.0 is unchanged and now reachable.

Assets 3
Loading