Skip to content

Update gltf2 + draco extension loader.#3

Merged
donmccurdy merged 24 commits into
donmccurdy:feat-gltf-draco-extensionfrom
fanzhanggoogle:draco_threejs_gltf_loader
Jul 12, 2017
Merged

Update gltf2 + draco extension loader.#3
donmccurdy merged 24 commits into
donmccurdy:feat-gltf-draco-extensionfrom
fanzhanggoogle:draco_threejs_gltf_loader

Conversation

@fanzhanggoogle
Copy link
Copy Markdown

Hi Don,
I've updated the branch. Mostly merge with dev and some minor fixes. I've been using this branch to test other gltf exporter with draco extension (e.g. gltf-pipeline, collada2gltf). Let me know how you want to proceed. We hope to get it ready so we could merge to main 3JS repo when the draco extension spec is settled. Thanks.

@donmccurdy

@donmccurdy donmccurdy force-pushed the feat-gltf-draco-extension branch 2 times, most recently from bad6b18 to 0f8069b Compare July 12, 2017 00:01
@donmccurdy donmccurdy merged commit b105295 into donmccurdy:feat-gltf-draco-extension Jul 12, 2017
@donmccurdy
Copy link
Copy Markdown
Owner

Thanks! I went ahead and merged this, but do have a couple concerns:

  1. It appears that isVersionSupported(version, callback) is never invoking the callback. Is this a known issue?
  2. I'm nervous about the way we're using a callback and trusting that it will actually be invoked synchronously. I will refactor loadMeshes so that things would not fail if the callback were really asynchronous.

@donmccurdy
Copy link
Copy Markdown
Owner

I cleaned up (2) above, so that the geometries can be loaded asynchronously.

See: https://github.com/mrdoob/three.js/compare/dev...donmccurdy:feat-gltf-draco-extension?diff=split

@fanzhanggoogle
Copy link
Copy Markdown
Author

Sorry for the late reply. Thanks for mention that. Since we are in the middle of a new bitstream release, I'll fix that once we settled on the release.

@donmccurdy
Copy link
Copy Markdown
Owner

Great! Do you expect that would be days, weeks, or...? Should I try to merge this to three.js in the meantime, or wait until the bitstream update?

@fanzhanggoogle
Copy link
Copy Markdown
Author

@donmccurdy I have a fix for the isVersionSupported, but currently waiting for the Webassembly pull request to be merged PR. Meanwhile, we plan to release the 1.0 in the coming weeks. Most of the work is ready, just need to refine some API.

donmccurdy pushed a commit that referenced this pull request Nov 15, 2018
Merge the new version code.
donmccurdy pushed a commit that referenced this pull request Apr 20, 2019
Update THREE JS fork
donmccurdy pushed a commit that referenced this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants