Add result message when updating profile#470
Conversation
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
==========================================
- Coverage 63.35% 63.24% -0.11%
==========================================
Files 109 110 +1
Lines 2524 2541 +17
Branches 414 415 +1
==========================================
+ Hits 1599 1607 +8
- Misses 796 805 +9
Partials 129 129
Continue to review full report at Codecov.
|
|
I'll take your opinion into consideration and modify the code. :) |
hyochan
left a comment
There was a problem hiding this comment.
@dooboo-ui/snackbar is deprecated.
Please use SnackBar in dooboo-ui.
0916dhkim
left a comment
There was a problem hiding this comment.
@woosanggyu Thank you for your contribution. I left some suggestions below. Also, I think it will be best to discuss the addition of toastBackground color in WeHack slack channel.
0916dhkim
left a comment
There was a problem hiding this comment.
Looks good to me! Approved ✔️

Specify project
client
Description
Display result message when updating profile
light.mov
dark.mov
Related Issues
none
Tests
I added the following tests:
N/AChecklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.yarn lint && yarn tscyarn testoryarn test -uif you need to update snapshot.[wehack2021]-[Cloud]