Fix sign up status message#472
Conversation
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
==========================================
- Coverage 64.52% 64.51% -0.02%
==========================================
Files 110 110
Lines 2599 2598 -1
Branches 431 430 -1
==========================================
- Hits 1677 1676 -1
- Misses 793 798 +5
+ Partials 129 124 -5
Continue to review full report at Codecov.
|
|
I'll make another commit, if #470 adds |
| <View style={{zIndex: 101}}> | ||
| <Snackbar testID="profile-snackbar" theme={theme} ref={snackbarRef} /> | ||
| </View> |
There was a problem hiding this comment.
I've asked in #470 to put this in RootStack for reusability.
I think you might want to talk to @woosanggyu who is going to work on this :)
There was a problem hiding this comment.
#470 is merged, and this PR is ready to be merged :)
rarira
force-pushed
the
fix_signUp_statusMessage
branch
from
e684f4e to
c70a7a3
Compare
hyochan
left a comment
hyochan
left a comment
There was a problem hiding this comment.
I think you can continue this work after rebasing to master.
rarira
force-pushed
the
fix_signUp_statusMessage
branch
from
c70a7a3 to
25bcb44
Compare
hyochan
left a comment
hyochan
left a comment
There was a problem hiding this comment.
LGTM~! Thanks for the great work again 🥇
2 participants
Specify project
client
Description
Related PR : #457
Some improvement and fix :
The "input-status" EditText of
SignUpcomponent should also have textInputProps.maxLength=60 props.By the way, Writing status while signup process looks bit weird, so it might be needless.
Use dooboo-ui
Snackbarcomponent for better UI ofAdded to your friendmessageRelated Issues
N/A
Tests
Updated ProfileModal test code:
now checks if snackbar rendered
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.yarn lint && yarn tscyarn testoryarn test -uif you need to update snapshot.[wehack2021]-[cloud]