Skip to content
This repository was archived by the owner on May 7, 2023. It is now read-only.

Add result message when updating profile#470

Merged
0916dhkim merged 9 commits into
hyochan:masterfrom
woosanggyu:feature/SangGyu
Aug 31, 2021
Merged

Add result message when updating profile#470
0916dhkim merged 9 commits into
hyochan:masterfrom
woosanggyu:feature/SangGyu

Conversation

@woosanggyu
Copy link
Copy Markdown
Contributor

@woosanggyu woosanggyu commented Aug 24, 2021

Specify project

client

Description

Display result message when updating profile

light.mov
dark.mov

Related Issues

none

Tests

I added the following tests:
N/A

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

[wehack2021]-[Cloud]

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 24, 2021

Codecov Report

Merging #470 (4a064ed) into master (be370eb) will decrease coverage by 0.10%.
The diff coverage is 47.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage   63.35%   63.24%   -0.11%     
==========================================
  Files         109      110       +1     
  Lines        2524     2541      +17     
  Branches      414      415       +1     
==========================================
+ Hits         1599     1607       +8     
- Misses        796      805       +9     
  Partials      129      129              
Impacted Files Coverage Δ
client/src/providers/SnackbarProvider.tsx 30.76% <30.76%> (ø)
client/src/components/pages/ProfileUpdate.tsx 50.58% <100.00%> (+2.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be370eb...4a064ed. Read the comment docs.

@hyochan hyochan added the 🎯 feature New feature label Aug 24, 2021
Copy link
Copy Markdown
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

However, we already have similar component in dooboo-ui. See the demo and navigate to [Snackbar].

Screen Shot 2021-08-24 at 6 11 35 PM

Could you try the above component? I think we don't need extra dep here.

@woosanggyu
Copy link
Copy Markdown
Contributor Author

woosanggyu commented Aug 24, 2021

I'll take your opinion into consideration and modify the code. :)

Comment thread client/src/components/pages/ProfileUpdate.tsx Outdated
Comment thread client/src/components/pages/ProfileUpdate.tsx Outdated
Comment thread client/src/components/pages/ProfileUpdate.tsx Outdated
This was referenced Aug 25, 2021
Copy link
Copy Markdown
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dooboo-ui/snackbar is deprecated.

Please use SnackBar in dooboo-ui.

Copy link
Copy Markdown
Collaborator

@0916dhkim 0916dhkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@woosanggyu Thank you for your contribution. I left some suggestions below. Also, I think it will be best to discuss the addition of toastBackground color in WeHack slack channel.

Comment thread client/assets/langs/en.json Outdated
Comment thread client/package.json Outdated
Comment thread client/src/components/navigations/RootStackNavigator.tsx Outdated
Comment thread client/src/theme.ts Outdated
Comment thread client/src/components/pages/ProfileUpdate.tsx Outdated
Comment thread client/src/components/pages/ProfileUpdate.tsx Outdated
Comment thread client/src/components/pages/ProfileUpdate.tsx Outdated
Copy link
Copy Markdown
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hyochan hyochan requested a review from 0916dhkim August 30, 2021 14:43
Copy link
Copy Markdown
Collaborator

@0916dhkim 0916dhkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Approved ✔️

Comment thread client/src/App.tsx
@0916dhkim 0916dhkim merged commit 758429c into hyochan:master Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🎯 feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants