Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Jianshu (简书) platform detection support by implementing a new detector that uses Jianshu's settings API to retrieve user information.
Related Issue
N/A
Type of Change
Changes Made
packages/detection/src/platforms/jianshu.jsdetectJianshuUser()function that fetches user data from Jianshu's settings API endpointconvertAvatarToBase64utility functionpackages/detection/src/detect.jsImplementation Details
The Jianshu detector works as follows:
https://www.jianshu.com/settings/basic.jsonwith authenticated credentials{ loggedIn: false }if request failsjson.data.nicknamefieldjson.data.avatarfieldconvertAvatarToBase64()with referrer 'https://www.jianshu.com/'{ loggedIn: true, username, avatar }{ loggedIn: false, error: e.message }on failureKey features:
Manual Testing Steps
{ loggedIn: false }Screenshots/Videos
If applicable, add screenshots or videos to demonstrate the changes
Reviewer Checklist
For reviewers to verify before merging: