fix(review-I): restore 失败安全补全 + E2E-05/08 用例有效性强化 - #18
Merged
Conversation
…ating Fourth review P1s on test validity: E2E-05 (pool shrink proof) - ensures TWO healthy instances before killing one warp-svc; records the killed pid; the survivor must keep serving warp=on during the shrink window. Single-instance runs no longer produce vacuous passes. E2E-08 (rebind actually restarts) - InstanceView now exposes restarts (RuntimeRegistry.restart_count). - ZT rebind and the no-credential fallback both gate on restarts incrementing after PATCH: a healthy state alone could return instantly since the instance was already healthy, and account.profile_id comes from desired spec - neither proves a real restart happened. - fallback branch no longer performs a no-op null->null rebind claim; it asserts the auto-restart via restarts instead. Also: compose.override.yml added to .gitignore (local diagnostic).
Every PR commit was running the full matrix TWICE (push event on the
branch + pull_request event), and docker-e2e doubled the most expensive
job (~8 min) the same way - a major Actions-minutes burner for a private
repo.
Both workflows now share one group per branch
(${workflow}-${head_ref||ref}) with cancel-in-progress, so consecutive
pushes supersede each other and the branch-push run is cancelled by its
pull_request twin (or vice versa).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
第四轮审查收尾批次。
#8 restore staging 补全（P1）
l)/硬链接(h) 条目（原 find 方案 argv 错误且时机过晚）/backup改只读挂载，提取动作不可能影响宿主备份目录E2E-05 池缩证明强化（P1）
E2E-08 restarts 门控（P1）
InstanceView暴露restarts（RuntimeRegistry.restart_count）附带：compose.override.yml 入 .gitignore（本地诊断文件）。
验证