Report links to inactive items as inactive, not unknown - #802
Merged
jacebrowning merged 1 commit intoJul 26, 2026
Merged
Conversation
Tree.find_item() and Document.find_item() skip inactive items, so
ItemValidator._get_issues_tree() never received an inactive parent and
its 'linked to inactive item' branch was unreachable. Validation of a
link to an inactive item raised DoorstopError('no item with UID: ...')
instead of the intended DoorstopInfo.
Both lookups gain an include_inactive flag (default False, so the
existing behaviour is unchanged for every other caller) and the
validator opts in.
Adds a regression test asserting the unknown-item error is no longer
logged when the parent exists but is inactive.
jacebrowning
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #726.
Tree.find_item()andDocument.find_item()skip inactive items, soItemValidator._get_issues_tree()never saw an inactive parent and itslinked to inactive itembranch was unreachable — the lookup raised instead, and the link was reported aslinked to unknown item(aDoorstopError) rather than the intendedDoorstopInfo.Both lookups gain an
include_inactiveflag defaulting toFalse, so every other caller is unchanged, and the validator opts in. The new test fails ondevelopwith the unknown-item error and passes with the fix.