-
Notifications
You must be signed in to change notification settings - Fork 40
Uncategorize capabilities #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Updates the `id` for the core model `app` --> `core-model` * Adds in-page anchors to the links from the "AI" and "Core" tags on the capabilities pages * Adds a test to verify
This now goes to the anchor on the core model on the research home page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively removes the categorization of capabilities, simplifying the structure and focusing on core and ai designations. The changes are comprehensive, touching on layouts, styling, and updating links to use in-page anchors. The removal of the sidebar and the alphabetical listing of capabilities on the main capabilities page are great improvements for user experience. The tests have been diligently updated to reflect these changes.
Why did the coffee file a police report? It got mugged!
|
Visit the preview URL for this PR (updated for commit 440006d): https://doradotdev--pr1255-drafts-on-iljtszrs.web.app (expires Sat, 17 Jan 2026 16:08:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7ad2b3cf9cceb558b493931176f998ae46924361 |
|
Visit the preview URL for this PR (updated for commit b52deda): https://doradotdev--pr1255-drafts-off-0wxzaiaf.web.app (expires Sat, 17 Jan 2026 16:30:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7ad2b3cf9cceb558b493931176f998ae46924361 |
davidstanke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
With the addition of the AI capabilities, it's time to move away from the "climate for learning," "fast flow," and "fast feedback" categories for capabilities. We will maintain the
coreoraidesignations.Summary of changes:
coreandaitags link to in-page anchors to the top of the interactive modelsdivid for the core model changed fromapptocore-modelPreview URLs:
Fixes #1227