#26273 Supporting VanityURL with action equals to 200 in Experiment#26803
Merged
freddyDOTCMS merged 3 commits intomasterfrom Nov 28, 2023
Merged
Conversation
jdotcms
reviewed
Nov 27, 2023
| } | ||
| } | ||
|
|
||
| @NotNull |
Member
Author
There was a problem hiding this comment.
jdotcms
reviewed
Nov 27, 2023
| } | ||
|
|
||
| @NotNull | ||
| private static String getVanityUrlsRegex(Host host, Language language, HTMLPageAsset htmlPageAsset) throws DotDataException { |
Member
Author
There was a problem hiding this comment.
jdotcms
reviewed
Nov 27, 2023
| .findByForward(host, language, htmlPageAsset.getURI(), 200) | ||
| .stream() | ||
| .map(vanitysUrls -> String.format(DEFAULT_URL_REGEX_TEMPLATE, vanitysUrls.pattern)) | ||
| .collect(Collectors.joining("|")); |
Member
Author
There was a problem hiding this comment.
jdotcms
reviewed
Nov 27, 2023
|
0.0% Coverage on New Code
0.0% Duplication on New Code
jdotcms
approved these changes
Nov 27, 2023
victoralfaro-dotcms
approved these changes
Nov 28, 2023
victoralfaro-dotcms
approved these changes
Nov 28, 2023
freddyDOTCMS
deleted the
issue-26273-Experiments-not-Considering-Redirection-from-Vanity-URLs
branch
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
https://github.com/dotCMS/core/pull/26803/files#diff-2069a2eff51802af984f2ef6b926adc6e8d91779ea57354c6f52d975fc857842R65