chore(maven) Cleanup maven docker processes including postman#27461
Merged
chore(maven) Cleanup maven docker processes including postman#27461
Conversation
67de680 to
fcaff62
Compare
wezell
reviewed
Feb 1, 2024
wezell
approved these changes
Feb 1, 2024
Member
wezell
left a comment
There was a problem hiding this comment.
Minor question on a file - looks great outside that.
9a5bf1d to
f3ec573
Compare
wezell
reviewed
Feb 7, 2024
9355721 to
f2fd756
Compare
wezell
added a commit
that referenced
this pull request
Feb 9, 2024
wezell
added a commit
that referenced
this pull request
Feb 9, 2024
auto-merge was automatically disabled
February 9, 2024 22:28
Merge queue setting changed
5d6c6ff to
6491f15
Compare
b4d3a78 to
f9aaad7
Compare
nollymar
approved these changes
Feb 21, 2024
victoralfaro-dotcms
approved these changes
Feb 21, 2024
e6ef111 to
e75088f
Compare
e7d3767 to
80232c4
Compare
9ccba86 to
f1225ea
Compare
|
spbolton
added a commit
to spbolton/core
that referenced
this pull request
Feb 28, 2024
…#27461) * Fix docker build * Only run sonar for PR and master branches * Only run sonar for PR and master branches * prevent failure on sonar timeout
spbolton
added a commit
to spbolton/core
that referenced
this pull request
Feb 28, 2024
…#27461) * Fix docker build * Only run sonar for PR and master branches * Only run sonar for PR and master branches * prevent failure on sonar timeout
This was referenced Apr 14, 2026
mbiuki
added a commit
that referenced
this pull request
Apr 15, 2026
Fixes #35339 parent/pom.xml referenced dependency-check-suppressions.xml which has never existed, causing the security-check profile to run with zero suppressions since Feb 2024 (commit 62e8d60 / PR #27461). The actual suppression file is owasp-suppressions.xml at the repo root (21 documented false-positive suppressions for Elasticsearch client JARs). Correcting the filename so the plugin loads them. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Changes
checkout "justfile" in root of project for examples of maven commands
Optionally These can be listed and run by
brew install justthen type "just" in the project directories to list the command options. e.g.
just clean-build
This change creates a shared docker configuration for build and run, including the db and search services the defaults are configured in parent/pom.xml. Using this structure makes it easier for other modules like dotcms-core, dotcms-integration, and dotcms-postman to startup services with the same configuration. Individual modules can override elements of the shared configuration to set ports, modify environment variables etc if required. Modules can also decide whether dotcms needs to run as well as its services or just the services e.g. for dotcms-integration we do not startup dotcms in a socker container.
The docker-maven-plugin https://dmp.fabric8.io/ Gives us a lot of flexibility and configuration we can make use of. In particular the default config is set up to automatically use different volumes and container names for each module to prevent clashes. By default also local ports are created dynamically although a module or user can set a port if they choose.
The locally built snapshot docker is used by default but any image can be specified on the command line this along with the ability to provide a unique context name allows multiple versions of dotcms with matching data to be running concurrently and reused. This will make it a lot simpler to compare a released version behavior against local behavior as well as maintaing a context to use for upgrade testing.
By default the current context is stored in named docker volumes, there is a configuration option to map to the filesystem instead although use of this should be discussed if required.
Not all available options have been exposed and there are many more ways we can used this.