Task(Indices) Create a new mechanism to track stored indices and their version #34146 #34169
+2,212
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tCMS/core into issue-34146-versioned-indices
dario-daza
approved these changes
Dec 29, 2025
nollymar
reviewed
Jan 8, 2026
| ContentDriveHelperContentletAPIComparisonTest.class, | ||
| AppsAPIImplTest.class, | ||
| Task251103AddStylePropertiesColumnInMultiTreeTest.class, | ||
| Task251212AddVersionColumnIndicesTableTest.class, |
Contributor
There was a problem hiding this comment.
Add this test at the end of the list
nollymar
reviewed
Jan 8, 2026
| */ | ||
| @ApplicationScoped | ||
| @RunWith(JUnit4WeldRunner.class) | ||
| public class VersionedIndicesAPITest { |
Contributor
There was a problem hiding this comment.
This class has not been added to the test suite
nollymar
reviewed
Jan 8, 2026
| * It provides functionality for loading, saving, removing, and inspecting indices and their versions. | ||
| * It also includes utilities for constructing indices objects from database query results. | ||
| */ | ||
| public interface IndicesFactory { |
Contributor
There was a problem hiding this comment.
if we are creating an IndicesFactory and Impl, we should deprecate the old one, shouldn't we?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR fixes: #34146