-
Notifications
You must be signed in to change notification settings - Fork 480
chore(style-editor): Remove defaultvalues from SDK and update README #34277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
KevinDavilaDotCMS
merged 5 commits into
main
from
34259-task-update-sdk-without-defaultvalues-and-update-readmes-and-examples-for-style-editor
Jan 13, 2026
Merged
chore(style-editor): Remove defaultvalues from SDK and update README #34277
KevinDavilaDotCMS
merged 5 commits into
main
from
34259-task-update-sdk-without-defaultvalues-and-update-readmes-and-examples-for-style-editor
Jan 13, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
… form handling - Updated the style editor form components to eliminate default values from the schema, ensuring that fields are initialized with null or empty values instead. - Introduced a new utility function, , to filter out null and undefined values before sending data to the API. - Adjusted the form builder service to handle initial values more effectively, ensuring that the form reflects the current state accurately. - Updated unit tests to verify the new behavior of form initialization and value filtering. This change improves the clarity of form data handling and enhances the user experience by ensuring that only meaningful values are submitted.
- Added a new section in the README.md for the Style Editor, detailing its purpose, benefits, and use cases. - Included a Quick Start guide for installation and schema definition. - Documented various field types supported by the Style Editor, including input, dropdown, radio, and checkbox group. - Provided examples for defining schemas and utilizing the Style Editor in both React and vanilla JavaScript. - Enhanced the documentation with best practices and a complete example to facilitate user understanding and implementation. This update significantly improves the clarity and usability of the Style Editor feature for developers.
Open
5 tasks
Open
5 tasks
- Changed the definition of StyleEditorRadioOption to only accept StyleEditorRadioOptionObject, removing the string type option. - This change simplifies the type handling for radio options in the style editor, ensuring consistency and reducing potential errors. This update enhances type safety within the style editor component.
…f strings - Modified the radio options in the style editor to use an object format, enhancing clarity and consistency. - Updated unit tests to reflect the new structure of options, ensuring they validate the expected object format. This change improves type safety and aligns with recent updates to the StyleEditorRadioOption type definition.
zJaaal
approved these changes
Jan 13, 2026
zJaaal
reviewed
Jan 13, 2026
dario-daza
approved these changes
Jan 13, 2026
rjvelazco
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2026-01-11.15-03-21.mov
This PR fixes: #34259
This PR fixes: #34259