34275 host or folder field issues #34590
Merged
+263
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated development settings: consolidated outputPath and baseHref for clarity. - Enabled source maps and named chunks for better debugging. - Enhanced serve options with continuous mode and default configuration for development. - Added production configuration for build target specification. These changes streamline the build process and improve development experience.
- Introduced tests to verify the behavior of loadChildren method when loading folder children. - Ensured that the method correctly updates nodes without children and avoids overwriting existing children. - Enhanced test coverage for the HostFolderFiledStore to improve reliability and maintainability.
1 task
1 task
- Updated the #createPaths method to simplify path normalization by directly splitting the input path. - Enhanced logic to remove the last segment if it is 'index', addressing potential issues with backend URL handling. - This change improves the consistency of URL processing and ensures that default routes are handled correctly.
…/core into 34275-host-or-folder-field-issues
Contributor
Author
|
@claude code review |
Contributor
There was a problem hiding this comment.
Pull request overview
Improves dotCMS UI host/folder field browsing by making folder-tree construction more resilient to paginated folder responses, preventing unintended tree overwrites on expand, and adjusting local dev build/serve settings.
Changes:
- Refactors
DotBrowsingServicefolder TreeNode creation and enhancesbuildTreeByPathsto handle missing parent folders across paginated responses. - Adds a safeguard in
HostFolderFiledStore.loadChildrento avoid reloading/overwriting existing children. - Updates
dotcms-uidevelopment build/serve configuration and adds/adjusts related unit tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| core-web/libs/ui/src/lib/services/dot-browsing/dot-browsing.service.ts | Refactors folder node creation and injects missing parent nodes into paginated responses during tree building. |
| core-web/libs/ui/src/lib/services/dot-browsing/dot-browsing.service.spec.ts | Adds coverage for the “missing parent in paginated response” tree-building scenario. |
| core-web/libs/edit-content/src/lib/fields/dot-edit-content-host-folder-field/store/host-folder-field.store.ts | Prevents loadChildren from overwriting existing node children. |
| core-web/libs/edit-content/src/lib/fields/dot-edit-content-host-folder-field/store/host-folder-field.store.spec.ts | Adds tests validating loadChildren behavior for nodes with/without existing children. |
| core-web/apps/dotcms-ui/project.json | Tweaks development build output and serve behavior for local dev workflow. |
core-web/libs/ui/src/lib/services/dot-browsing/dot-browsing.service.ts
Outdated
Show resolved
Hide resolved
...t-content/src/lib/fields/dot-edit-content-host-folder-field/store/host-folder-field.store.ts
Outdated
Show resolved
Hide resolved
…handling - Changed the logic to access the last segment of the split path array directly instead of using the `at()` method, enhancing readability and performance. - This update ensures consistent handling of paths, particularly when dealing with default routes like '/index'. No functional changes were introduced, maintaining existing behavior while improving code clarity.
- Implemented a new test case to verify the behavior of loadChildren when a node has an empty children array. - Ensured that the method correctly calls getFoldersTreeNode and updates the node with the fetched folders. - Updated the loadChildren logic to handle nodes with empty children arrays while preventing overwriting existing children. This enhances test coverage and reliability of the HostFolderFiledStore functionality.
adrianjm-dotCMS
approved these changes
Feb 10, 2026
oidacra
reviewed
Feb 10, 2026
...t-content/src/lib/fields/dot-edit-content-host-folder-field/store/host-folder-field.store.ts
Show resolved
Hide resolved
oidacra
approved these changes
Feb 10, 2026
rjvelazco
approved these changes
Feb 10, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the folder tree loading and browsing logic in the dotCMS UI, focusing on better handling of paginated folder responses, preventing unnecessary tree overwrites, and improving test coverage. The changes also refine the build and serve configurations for the development environment.
Folder tree loading and browsing improvements:
DotBrowsingServiceto unshift the parent folder into the next paginated response when it is missing, ensuring the tree can be correctly built even when pagination omits intermediate folders. (Fa220796L139, core-web/libs/ui/src/lib/services/dot-browsing/dot-browsing.service.spec.tsR519-R596)#createFolderTreeNodefor clarity and reuse. [1] [2]#createPathsto handle default/indexroutes, preventing them from being treated as folders.Folder tree loading safeguards:
loadChildrenmethod inHostFolderFiledStoreto skip loading children if the node already has children, avoiding overwriting the tree and losing pagination-related injected items.Test coverage enhancements:
loadChildrento verify correct behavior when loading children for nodes with and without existing children.DotBrowsingServiceto ensure parent folders are correctly inserted into paginated responses, allowing the tree to be built properly.Development build and serve configuration changes:
project.jsonto enable source maps and named chunks, set properbaseHref, and improved theservetarget with continuous mode and live reload for development. [1] [2]Test file cleanup:
This PR fixes: #34275