feat(analytics): add breadcrumb IDs for conversions, engagement, and pageviews#34713
Merged
adrianjm-dotCMS merged 7 commits intoissue-33882-primeng-updatefrom Feb 23, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds stable breadcrumb IDs to dot-analytics dashboard report views so GlobalStore.addNewBreadcrumb() can reliably dedupe/track the last breadcrumb when these breadcrumbs don’t include URLs.
Changes:
- Add
idto the breadcrumb entries created by the Pageview, Engagement, and Conversions report components. - Update the Engagement report unit test expectation to include the new breadcrumb
id.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core-web/libs/portlets/dot-analytics/portlet/src/lib/dot-analytics-dashboard/reports/pageview/dot-analytics-pageview-report/dot-analytics-pageview-report.component.ts | Adds id: 'pageview' to the breadcrumb created for the Pageview report. |
| core-web/libs/portlets/dot-analytics/portlet/src/lib/dot-analytics-dashboard/reports/engagement/dot-analytics-engagement-report/dot-analytics-engagement-report.component.ts | Adds id: 'engagement' to the breadcrumb created on init for the Engagement report. |
| core-web/libs/portlets/dot-analytics/portlet/src/lib/dot-analytics-dashboard/reports/engagement/dot-analytics-engagement-report/dot-analytics-engagement-report.component.spec.ts | Updates the breadcrumb expectation to include id: 'engagement'. |
| core-web/libs/portlets/dot-analytics/portlet/src/lib/dot-analytics-dashboard/reports/conversions/dot-analytics-conversions-report/dot-analytics-conversions-report.component.ts | Adds id: 'conversions' to the breadcrumb created on init for the Conversions report. |
...s/conversions/dot-analytics-conversions-report/dot-analytics-conversions-report.component.ts
Show resolved
Hide resolved
...rd/reports/pageview/dot-analytics-pageview-report/dot-analytics-pageview-report.component.ts
Show resolved
Hide resolved
…rumb-on-page-reload-analytics
Legal RiskThe following dependencies were released under a license that RecommendationWhile merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue. MPL-2.0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the breadcrumb setup for the analytics dashboard reports by adding a unique
idfield to each breadcrumb object. This change ensures that each report's breadcrumb can be uniquely identified, which helps to avoid the "Duplication" bug in analytics dashboard.DEMO:
Screen.Recording.2026-02-20.at.3.30.15.PM.mov
Breadcrumb improvements:
idfield to the breadcrumb object in thengOnInitmethod ofDotAnalyticsConversionsReportComponent, setting it to'conversions'.idfield to the breadcrumb object in thengOnInitmethod ofDotAnalyticsEngagementReportComponent, setting it to'engagement'.idfield to the breadcrumb object in the#setupBreadcrumbmethod ofDotAnalyticsPageviewReportComponent, setting it to'pageview'.Testing updates:
DotAnalyticsEngagementReportComponentto expect the newid: 'engagement'field in the breadcrumb object.This PR fixes: #34694
This PR fixes: #34694