Skip to content

Comments

feat(analytics): add breadcrumb IDs for conversions, engagement, and pageviews#34713

Merged
adrianjm-dotCMS merged 7 commits intoissue-33882-primeng-updatefrom
34694-duplicate-breadcrumb-on-page-reload-analytics
Feb 23, 2026
Merged

feat(analytics): add breadcrumb IDs for conversions, engagement, and pageviews#34713
adrianjm-dotCMS merged 7 commits intoissue-33882-primeng-updatefrom
34694-duplicate-breadcrumb-on-page-reload-analytics

Conversation

@adrianjm-dotCMS
Copy link
Contributor

@adrianjm-dotCMS adrianjm-dotCMS commented Feb 20, 2026

This pull request updates the breadcrumb setup for the analytics dashboard reports by adding a unique id field to each breadcrumb object. This change ensures that each report's breadcrumb can be uniquely identified, which helps to avoid the "Duplication" bug in analytics dashboard.

DEMO:

Screen.Recording.2026-02-20.at.3.30.15.PM.mov

Breadcrumb improvements:

  • Added an id field to the breadcrumb object in the ngOnInit method of DotAnalyticsConversionsReportComponent, setting it to 'conversions'.
  • Added an id field to the breadcrumb object in the ngOnInit method of DotAnalyticsEngagementReportComponent, setting it to 'engagement'.
  • Added an id field to the breadcrumb object in the #setupBreadcrumb method of DotAnalyticsPageviewReportComponent, setting it to 'pageview'.

Testing updates:

  • Updated the test for DotAnalyticsEngagementReportComponent to expect the new id: 'engagement' field in the breadcrumb object.

This PR fixes: #34694

This PR fixes: #34694

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds stable breadcrumb IDs to dot-analytics dashboard report views so GlobalStore.addNewBreadcrumb() can reliably dedupe/track the last breadcrumb when these breadcrumbs don’t include URLs.

Changes:

  • Add id to the breadcrumb entries created by the Pageview, Engagement, and Conversions report components.
  • Update the Engagement report unit test expectation to include the new breadcrumb id.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
core-web/libs/portlets/dot-analytics/portlet/src/lib/dot-analytics-dashboard/reports/pageview/dot-analytics-pageview-report/dot-analytics-pageview-report.component.ts Adds id: 'pageview' to the breadcrumb created for the Pageview report.
core-web/libs/portlets/dot-analytics/portlet/src/lib/dot-analytics-dashboard/reports/engagement/dot-analytics-engagement-report/dot-analytics-engagement-report.component.ts Adds id: 'engagement' to the breadcrumb created on init for the Engagement report.
core-web/libs/portlets/dot-analytics/portlet/src/lib/dot-analytics-dashboard/reports/engagement/dot-analytics-engagement-report/dot-analytics-engagement-report.component.spec.ts Updates the breadcrumb expectation to include id: 'engagement'.
core-web/libs/portlets/dot-analytics/portlet/src/lib/dot-analytics-dashboard/reports/conversions/dot-analytics-conversions-report/dot-analytics-conversions-report.component.ts Adds id: 'conversions' to the breadcrumb created on init for the Conversions report.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

@adrianjm-dotCMS adrianjm-dotCMS changed the base branch from main to issue-33882-primeng-update February 23, 2026 20:31
@semgrep-code-dotcms-test
Copy link

Legal Risk

The following dependencies were released under a license that
has been flagged by your organization for consideration.

Recommendation

While merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue.

MPL-2.0

@adrianjm-dotCMS adrianjm-dotCMS merged commit ae082f3 into issue-33882-primeng-update Feb 23, 2026
6 checks passed
@adrianjm-dotCMS adrianjm-dotCMS deleted the 34694-duplicate-breadcrumb-on-page-reload-analytics branch February 23, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area : Documentation PR changes documentation files Area : Frontend PR changes Angular/TypeScript frontend code

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[DEFECT] Duplicate Breadcrumb Items on Page Reload in Analytics Tabs

1 participant