feat(ci): orchestrate automatic and interactive Claude reviews#34810
feat(ci): orchestrate automatic and interactive Claude reviews#34810sfreudenthaler merged 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1cd8b89b4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
just needs someone from core workflow devs group. I should actually just widen that net or just make it any two ppl |
|
@sfreudenthaler Note that due to our current security model on the Repo generally external users cannot spam us with PRs. The primary reason for this is we only allow any interaction to the repo by "collaborators" so anyone needing write access to the repository needs to be approved including creating PRs. https://github.com/dotCMS/core/settings/interaction_limits. Interestingly there is a new configuration option just added that would not have impact with our current restriction, you you can now separately prevent access to creating PRs but allow access to the repo otherwise. This could mean you can allow access for external users to create issues, but not PRs. https://github.blog/changelog/2026-02-13-new-repository-settings-for-configuring-pull-request-access/ |
|
Generally fine. Just a couple of points.
|
Let me double check. I thought the orchestrator in ai-workflows handled this but I might have mistaken.
Yes :) early feedback for devs is worth the offset in token waste
Probably but lets see |
Move concurrency control from workflow level to job level so that automatic review cancellations on new pushes never interrupt an in-progress user @claude session. - claude-interactive: cancel-in-progress: false (protect user sessions) - claude-automatic-review: cancel-in-progress: true (always review latest) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sfreudenthaler
left a comment
There was a problem hiding this comment.
ready for review again @spbolton
Summary
Non-functional considerations
Validation
Closes #34809