#34980 include exception in addBinaries#35045
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
Contributor
|
Claude finished @dsilvam's task in 46s —— View job Rollback Safety Analysis
Result: Safe to Rollback ✅The single-line change adds the exception object This is a pure logging improvement with no impact on:
None of the rollback-unsafe categories (C-1 through M-4) apply. |
gortiz-dotcms
approved these changes
Mar 20, 2026
dsolistorres
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Logger.warn()inDefaultTransformStrategy#addBinariesso the full stack trace is included in the warning log, not just the message string.Problem
When a binary field fails to be retrieved during contentlet transformation, the warning log only captured
e.getMessage()as a string argument. This meant the stack trace was silently dropped, making it very difficult to diagnose the root cause of binary retrieval failures.Solution
Pass
eas the third argument toLogger.warn(), which triggers the overload that logs both the message and the full exception stack trace.Test plan
This PR fixes: #34980