style/feat(ui-fixes): portlet UI standardization and push publish for plugins

[hmoreras]

Summary

• feat(dot-plugins): Add push publish action to the plugins portlet context menu. Wires up DotPushPublishEnvironmentsResolver and DotEnterpriseLicenseResolver on the route so the option appears when the instance has an enterprise license and at least one push publish environment configured — matching the pattern used in the locales portlet.
• style(dot-locales): Standardize the locales portlet UI to match current portlet conventions.
• style(dot-tags): Remove icons from the Add and Import toolbar buttons in the tags portlet.
• style(portlets): Standardize dialog widths, toolbar borders, and branding bar background across portlets.
• feat(plugins,tags): Apply the categories upload dialog error-handling pattern to plugins and tags portlets.
• fix(ui): Rename .checkbox/.radio wrapper classes to .form-checkbox/.form-radio to avoid DaisyUI collision.

Test plan

• Verify push publish option appears in the plugins portlet context menu when enterprise license is active and push publish environments are configured.
• Verify push publish option is hidden when no enterprise license or no environments are present.
• Verify the push publish dialog opens correctly and allows selecting an environment to publish to.
• Verify locales portlet UI matches portlet conventions.
• Verify tags portlet toolbar buttons no longer show icons for Add and Import.
• Run unit tests: yarn nx test portlets-dot-plugins-portlet

🤖 Generated with Claude Code

This PR fixes: #35274

This PR fixes: #35274

[claude]

Claude finished @hmoreras's task in 4m 12s —— View job

---

PR Review

• Gather context
• Read changed files
• Analyze for bugs, risks, and design issues
• Post review findings

---

Issues

1. #extractErrorMessage duplication is still unaddressed

Reviewer oidacra flagged this at dot-plugins-upload.component.ts:58; there's no author response and the implementation is unchanged. The method body is identical byte-for-byte in both files:

• core-web/libs/portlets/dot-plugins/src/lib/dot-plugins-upload/dot-plugins-upload.component.ts:78
• core-web/libs/portlets/dot-tags/src/lib/dot-tags-import/dot-tags-import.component.ts:101

A third portlet needing inline file-error handling will copy it again. Extract it to @dotcms/utils as extractHttpErrorMessage(error: HttpErrorResponse): string — getDownloadLink is already there as a model. Fix this →

---

2. viewChild claim about TypeScript access modifiers is incorrect

dot-locales-list.component.ts:64:

private readonly contextMenu = viewChild.required<ContextMenu>('rowMenu');

The author's response that "Angular's compiler requires TypeScript access modifiers (not ES private) for view queries" applied to the old @ViewChild() decorator. Signal-based viewChild() / viewChild.required() in Angular 19 has no such restriction — # works fine. This was also left un-fixed on dot-plugins-list.component.ts:91:

private readonly table = viewChild<Table>('dt');

Both should be readonly #contextMenu and readonly #table to be consistent with the rest of the refactor in this PR.

---

3. Missing test coverage for openRowMenu in locales

dot-locales-list.component.spec.ts has 4 tests, none of which exercise openRowMenu. The new behaviour being added — push publish menu item visibility, set-as-default guard, delete guard — is all in that method. A right-click that opens the menu with push publish enabled will silently do nothing wrong, but there's nothing catching regressions here.

Minimum coverage needed:

• Context menu items when isEnterprise: true and environments present (push publish visible)
• Context menu items when isEnterprise: false (push publish hidden)
• Set-as-default and delete hidden for the default locale itself

---

4. DotLocalesListStore services still use private readonly (not #)

dot-locales-list.store.ts:45-48:

private readonly languageService = inject(DotLanguagesService);
private readonly dotMessageService = inject(DotMessageService);
private readonly messageService = inject(MessageService);
private readonly dotHttpErrorManagerService = inject(DotHttpErrorManagerService);

The same # refactor applied to the component was not carried into the store. These are @Injectable() class fields with no decorator constraints — # applies cleanly here too.

---

5. Route data reads from shell's route, not the list's own route (subtle coupling)

In plugins, resolvers are on the shell route:

// lib.routes.ts
{ path: '', component: DotPluginsShellComponent, resolve: { ... } }  // resolvers here

DotPluginsListComponent is embedded in the shell template (not a routed component), so it inherits the shell's ActivatedRoute. This works today, but it's an implicit coupling that differs from the locales pattern (where resolvers are on the list's own child route). If DotPluginsListComponent is ever lifted into a standalone route without the shell, this.#route.snapshot.data would silently be empty, and pushPublishEnvironments.length > 0 would throw. The inconsistency between the two portlets is worth documenting in the route file, or aligning on the locales pattern.

---

Verified clean

• jarFile as push-publish assetIdentifier is correct — OSGIBundler.java:83 reads element.getAsset() as the jar filename
• viewChild.required for contextMenu is correct — the <p-contextMenu #rowMenu> is outside the @if (vm$ | async) block and is always in the DOM
• defaultLocale guard fix (!locale.defaultLanguage && defaultLocale) is correct