Skip to content

chore(claude): remove dotcms-frontend-review skill and exclusive agents#35400

Merged
oidacra merged 3 commits intomainfrom
remove-skills-agents
Apr 21, 2026
Merged

chore(claude): remove dotcms-frontend-review skill and exclusive agents#35400
oidacra merged 3 commits intomainfrom
remove-skills-agents

Conversation

@oidacra
Copy link
Copy Markdown
Member

@oidacra oidacra commented Apr 21, 2026

Summary

  • Removes .claude/skills/dotcms-frontend-review/ and its two exclusive agents (dotcms-code-reviewer, dotcms-test-reviewer). No other skills reference these agents.
  • Adds .venv/ to .gitignore.

Test plan

  • Confirm no remaining references to the removed skill/agents: git grep -E "dotcms-(frontend-review|code-reviewer|test-reviewer)"

oidacra added 2 commits April 21, 2026 11:22
…agents

Removes the dotcms-frontend-review skill along with dotcms-code-reviewer
and dotcms-test-reviewer agents, which were only used by that skill.
@github-actions
Copy link
Copy Markdown
Contributor

❌ Issue Linking Required

This PR could not be linked to an issue. All PRs must be linked to an issue for tracking purposes.

How to fix this:

Option 1: Add keyword to PR body (Recommended - auto-removes this comment)
Edit this PR description and add one of these lines:

  • This PR fixes #123 or Fixes: #123

  • This PR closes #123 or Closes: #123

  • This PR resolves #123 or Resolves: #123

  • Other supported keywords: fix, fixed, close, closed, resolve, resolved
    Option 2: Link via GitHub UI (Note: won't clear the failed check)

  1. Go to the PR → Development section (right sidebar)

  2. Click "Link issue" and select an existing issue

  3. Push a new commit or re-run the workflow to clear the failed check
    Option 3: Use branch naming
    Create a new branch with one of these patterns:

  • 123-feature-description (number at start)

  • issue-123-feature-description (issue-number at start)

  • feature-issue-123 (issue-number anywhere)

Why is this required?

Issue linking ensures proper tracking, documentation, and helps maintain project history. It connects your code changes to the problem they solve.---

This comment was automatically generated by the issue linking workflow

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 21, 2026

Claude finished @oidacra's task in 1m 15s —— View job


PR Review

  • Check for remaining references to removed skill/agents
  • Review .gitignore change
  • Verify deleted file contents are safe to remove

One stale reference remains after deletion: .claude/skills/skill-doctor/reference.md lines 587–593 uses dotcms-frontend-review as a concrete example in its "Diagnose Flow" section:

Developer: /skill-doctor dotcms-frontend-review

1. Validate: .claude/skills/dotcms-frontend-review/ exists (repo version, no local override)

This is doc-only and won't break anything, but the example will point at a non-existent path post-merge. The PR's own test plan (git grep -E "dotcms-(frontend-review|code-reviewer|test-reviewer)") would catch it — worth checking off that box. Fix this →

.gitignore change is fine.

Everything else is clean.

@oidacra
Copy link
Copy Markdown
Member Author

oidacra commented Apr 21, 2026

Tracking issue: #35402

@oidacra oidacra linked an issue Apr 21, 2026 that may be closed by this pull request
5 tasks
@oidacra oidacra added this pull request to the merge queue Apr 21, 2026
Merged via the queue into main with commit 1c9eb08 Apr 21, 2026
27 checks passed
@oidacra oidacra deleted the remove-skills-agents branch April 21, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

chore(claude): remove dotcms-frontend-review skill and exclusive agents

2 participants