Align superscript/subscript rendering in legacy block editor edit view#35414
Align superscript/subscript rendering in legacy block editor edit view#35414
Conversation
…nt in editor Agent-Logs-Url: https://github.com/dotCMS/core/sessions/c390e2d1-c2b0-415a-b9ef-3108f1a5f836 Co-authored-by: fmontes <751424+fmontes@users.noreply.github.com>
…ve in bubble menu Agent-Logs-Url: https://github.com/dotCMS/core/sessions/b71dcb15-cc56-412e-8a41-d2a471bb2454 Co-authored-by: fmontes <751424+fmontes@users.noreply.github.com>
…ion in bubble menu Agent-Logs-Url: https://github.com/dotCMS/core/sessions/b71dcb15-cc56-412e-8a41-d2a471bb2454 Co-authored-by: fmontes <751424+fmontes@users.noreply.github.com>
|
Claude finished @fmontes's task in 1m 56s —— View job PR Review
Incomplete mutual-exclusion fix — slash command path is not covered
// core-web/libs/block-editor/src/lib/extensions/action-button/actions-menu.extension.ts
subscript: () => editor.chain().setSubscript().focus().run(),
superscript: () => editor.chain().setSuperscript().focus().run(),A user who applies subscript via the bubble menu and then adds superscript via the CSS is correct but worth documenting why
Test calls protected method via bracket access component['toggleSuperscript']();Works at runtime, but if the method is renamed TypeScript won't catch the stale test reference. A small risk in a file that is otherwise well-structured. Everything else — the chain ordering, the mock design, the |
toggleSuperscript()andtoggleSubscript()methods todot-bubble-menu.component.tsthat unset the opposite mark before togglingdot-bubble-menu.component.htmlto call the new methodsdot-bubble-menu.component.spec.tsverifying both methods enforce mutual exclusion