fix(block-editor): correct image wrap icons and add missing i18n keys#35424
fix(block-editor): correct image wrap icons and add missing i18n keys#35424
Conversation
…#35420) Swaps the icon pairs on wrap-left/wrap-right buttons so they visually match the float direction they produce, and adds the missing wrap-left/wrap-right keys to Language.properties so tooltips render translated text instead of raw key strings. Refs: #35420 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Claude finished @fmontes's task in 1m 7s —— View job Rollback Safety Analysis
Result: ✅ Safe To RollbackThe changes in this PR touch only two files and fall into no unsafe rollback category:
Neither change matches any of the unsafe categories (C-1 through M-4). No database migrations, no Elasticsearch mapping changes, no API contract modifications, no structural data model changes. Label applied: AI: Safe To Rollback |
|
Claude finished @fmontes's task in 59s —— View job PR Review
Clean fix. Two small things worth checking: Icon ordering / margin direction The swap itself is correct: i18n: other locale files not updated Only No unit/spec changes The affected component ( |
Summary
Fixes two bugs in the Block Editor image text-wrap toolbar buttons introduced in #35211 (reported via FD #36727).
pi-align-left+pi-image(visually: text-left, image-right) butsetImageTextWrap('left')producesfloat: left— image on the left, text on the right. The icons were swapped between the two buttons. Fixed by usingpi-image+pi-align-rightfor wrap-left andpi-align-left+pi-imagefor wrap-right so each icon pair visually matches the layout it produces.Language.propertiesonly definedblock-editor.bubble-menu.image.properties. Thewrap-leftandwrap-rightkeys were absent, causing thedmpipe to render the raw key string as the tooltip. Addedblock-editor.bubble-menu.image.wrap-left=Wrap Leftandblock-editor.bubble-menu.image.wrap-right=Wrap Right.Files changed
core-web/libs/block-editor/src/lib/elements/dot-bubble-menu/dot-bubble-menu.component.html— swapped icon pairs on wrap-left/wrap-right buttonsdotCMS/src/main/webapp/WEB-INF/messages/Language.properties— added missing i18n keysTest plan
Closes #35420
🤖 Generated with Claude Code