refactor(uve): remove duplicate copy URL button from editor toolbar#35518
Merged
refactor(uve): remove duplicate copy URL button from editor toolbar#35518
Conversation
Contributor
|
Claude finished @zJaaal's task in 2m 21s —— View job Code Review
Clean removal overall. One leftover to fix.
// Mock createFullURL to avoid issues with invalid URLs in tests
jest.mock('../../../utils', () => ({
...jest.requireActual('../../../utils'),
createFullURL: jest.fn((params, siteId) => { ... })
}));
Everything else is clean — the HTML block and all five TypeScript symbols ( |
Closes #35517 The toolbar's "copy URL" popover became redundant once #35417 added the same control on the browser URL pill (where the URL itself is shown). Both buttons rendered the exact same $pageURLS popover and triggered the same toast, so the toolbar one is pure noise. - Remove the popover button from dot-uve-toolbar.component.html - Drop unused symbols from dot-uve-toolbar.component.ts: ClipboardModule, PopoverModule, $pageURLS, copyUrlPopoverPt, triggerCopyToast, and the createFullURL utility import - The browser-pill copy button (edit-ema-editor.component.*) is unchanged Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5485d83 to
29f0647
Compare
adrianjm-dotCMS
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent Issue
Closes #35517
Summary
The UVE editor was rendering the same "copy page URL" popover in two places:
pi pi-copy, next to the bookmark star)pi pi-link, on the pill that shows the URL itself)Both buttons opened the same
$pageURLSpopover and called the same toast. The pill version was added in #35417 when the URL pill itself was introduced. Since the URL now lives on the pill, the copy control belongs there — the toolbar one is pure duplication.This PR removes the toolbar copy button and cleans up the symbols that became unused.
Changes
dot-uve-toolbar.component.html— drop the<p-button>+<p-popover>blockdot-uve-toolbar.component.ts— removeClipboardModule,PopoverModule,$pageURLS,copyUrlPopoverPt,triggerCopyToast, and thecreateFullURLimportedit-ema-editor.component.*— unchanged; the pill copy button staysTest plan
yarn nx lint portlets-edit-ema-portlet— clean (only pre-existing warnings in another file)yarn nx test portlets-edit-ema-portlet— 63 suites, 1331 passed, 5 skipped🤖 Generated with Claude Code
This PR fixes: #35517