fix(ci): gate Docker :latest and "Next Release" relabel to main only#35652
Conversation
The -6 release workflow is dispatchable from any branch, but it unconditionally pushed the :latest Docker tag and relabeled GitHub issues tagged "Next Release" with the dispatched release_version. When a release was run from a non-main branch (e.g. 26.04.11), this overwrote :latest with a non-main image and stamped main-only fixes with a release version that did not actually contain them. Add a `github.ref_name == 'main'` guard to both the deployment phase's `latest` input and the release phase's `update_github_labels` input so these side effects fire only when releasing from main. Refs #35651 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Claude finished @erickgonzalez's task in 1m 17s —— View job Claude PR Review
The change is correct and well-scoped. Two minor things to consider, neither blocking. Verification
Nits (non-blocking)
SummaryClean fix. The two added |
Summary
-6 Release Processworkflow can be dispatched from any branch, but it unconditionally pushed Docker:latestand relabeled GitHub issues taggedNext Releasewith the dispatchedrelease_version.mainbranch (e.g.26.04.11), this overwrote:latestwith a non-mainimage and stampedmain-only fixes with a release version that did not actually contain them.github.ref_name == 'main'guard to the deployment phase'slatestinput and the release phase'supdate_github_labelsinput so these two side effects fire only when releasing frommain.Plugin updates, Artifactory deploy, javadocs upload, SBOM, and Slack notification remain controllable via their existing workflow inputs and are intentionally not branch-gated — they are legitimate from non-
mainrelease branches.Closes #35651
Test plan
-6 Release Processfrom a non-mainbranch with a standard version (e.g.26.04.11-01) andupdate_github_labels = true. Confirm:deploy-dockerstep does not push the:latesttag.Next Releaseissues.-6 Release Processfrommainwith a standard version. Confirm::latestis pushed (existing behavior).Next Releaseissues are relabeled (existing behavior).mainwith an LTS version (e.g.26.04.11_lts_v01). Confirm:latestis not pushed (pre-existing LTS behavior preserved).🤖 Generated with Claude Code
This PR fixes: #35651