feat(Content Analytics) #35525 : Add docker-compose examples for Experiments and new CA infrastructure.#35678
Conversation
…riments and new CA infrastructure.
|
Claude finished @jcastro-dotcms's task in 1m 3s —— View job PR ReviewSmall, low-risk cleanup. A few notes worth a second look: 1. PR title vs. actual diff mismatch — Title says "Add docker-compose examples for Experiments and new CA infrastructure," but the only diff in this PR (branch suffix 2. External path reference is a broken-link risk —
3. Removed env vars from
4. Missing trailing newline in Not blocking, but worth confirming: does the external repo's If the title gets fixed and #3's security default is confirmed, this is good to go. |
@claude regarding your feedback:
|
|
Claude finished @jcastro-dotcms's task in 33s —— View job Response to your feedbackAcknowledged on all three points — those are reasonable calls and consistent with the PR being part of a larger change set. Quick confirmation on the one remaining item from my review (the security flag default): I checked the codebase — the default for
So removing No further blockers from my side. Good to go once the linked external repo PR lands.
|
Summary
This is Part 2 of the work for #35525. It cleans up two issues introduced alongside the new Content Analytics docker-compose examples:
Changes
1. Fix stale directory reference in
analytics/README.mdThe README was pointing readers to the
docker/root of thedot-ca-event-managerrepo, which is too broad. Updated to point directly todocker/analytics-infra-example/— the actual directory containing the ClickHouse keeper, replica nodes, init scripts, and event manager service.2. Remove hardcoded analytics env vars from
single-node/docker-compose.ymlThe generic single-node example had analytics-specific environment variables baked in:
These don't belong in a general-purpose compose file — they expose internal credentials as defaults, enable a feature flag globally, and cause confusion for developers not working with analytics. These settings now live exclusively in the analytics-specific compose example where they are relevant.
Why it matters
Testing
single-node/docker-compose.ymlstarts cleanly without the removed varsanalytics/README.mdlink resolves to the correct directory indot-ca-event-managerThis PR fixes: #35525
This PR fixes: #35525