chore(tiptap): pin @tiptap/core resolution#35685
Merged
rjvelazco merged 3 commits intoMay 12, 2026
Merged
Conversation
13 tasks
KevinDavilaDotCMS
approved these changes
May 12, 2026
Contributor
|
Claude finished @rjvelazco's task in 47s —— View job Rollback Safety Analysis — ✅ Safe To Rollback
FindingsThis PR is frontend-only. Three changed files, none touching anything in the rollback-unsafe category set:
No matches against any unsafe category:
N-1 can serve all traffic unchanged after rollback. The only effect would be the absence of the new Tiptap code-block extension in the Block Editor UI; the bundle-budget change is build-time only and has no production impact. |
Contributor
|
Claude finished @rjvelazco's task in 51s —— View job Rollback Safety Analysis — ✅ Safe To Rollback
FindingsThis PR only touches frontend Node dependencies:
No matches against any unsafe category:
N-1 can serve all traffic unchanged after rollback; the only effect would be the absence of the new Tiptap code-block extension in the Block Editor UI. |
Adding `@tiptap/extension-code-block` as a direct dependency in the sibling commit pushed the production initial bundle 524 bytes past the 5mb hard error budget. Bump the ceiling to 6mb so the build passes; the 2mb warning threshold stays as-is so we still see drift in CI logs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Unblocks
yarn nx serve dotcms-uiafter the Block Editor 2.0 merge (#35257). Two small TipTap dependency-resolution fixes incore-web/package.json:Pin
@tiptap/coreviaresolutions—@tiptap/starter-kitdeclares@tiptap/core: ^3.22.2, which yarn was resolving to3.23.1(a minor bump). That left two copies of@tiptap/coreundernode_modules(root3.22.2+ nestedstarter-kit/node_modules/@tiptap/core@3.23.1). TypeScript treats the two type definitions as incompatible, so the legacylibs/block-editorbroke withType 'Extension<StarterKitOptions>' is not assignable to type 'AnyExtension'plus a cascade ofProperty 'toggleHeading' does not exist on type 'ChainedCommands'-style errors. The resolution forces a single shared copy.Add
@tiptap/extension-code-block@3.22.2as a direct dependency —@tiptap/extension-code-block-lowlightdeclares it as a peer dependency. Yarn 1 does not auto-install peers; after the dedup above, this package landed nested understarter-kit/node_modules/rather than hoisted, so esbuild could not resolve it at bundle time (Could not resolve "@tiptap/extension-code-block"). Promoting it to a top-level dep guarantees hoisting and version consistency with the rest of the TipTap suite.A minor
package.jsonreorder also moveslint-stagedto its alphabetical position indevDependencies(no behavioural change).Why this is needed
The Block Editor 2.0 merge worked on CI (
yarn install --frozen-lockfileagainst the merge-time lockfile), but a fresh localyarn installafter pullingmainre-resolves the lockfile and trips on both issues above. Anyone pulling main since the merge hits the same compile errors when running the dev server.Test plan
yarn installruns clean — no missing-peer-dep warnings for the affected packages.@tiptap/coreresolves undernode_modules(find node_modules -path '*/@tiptap/core/package.json').@tiptap/extension-code-blockis hoisted tonode_modules/@tiptap/extension-code-block/.yarn nx serve dotcms-uicompletes the initial bundle and listens onhttp://localhost:4200/dotAdmin— noCannot find module/Could not resolve/ TipTap type errors.libs/block-editoror the newlibs/new-block-editortype checks.Related
attrs, spell-check, and table-actions items in that issue remain in scope for separate work.🤖 Generated with Claude Code
This PR fixes: #35683