fix(docker): install cached custom starter on container restart#35789
Open
wezell wants to merge 2 commits into
Open
fix(docker): install cached custom starter on container restart#35789wezell wants to merge 2 commits into
wezell wants to merge 2 commits into
Conversation
The startup script only exported DOT_STARTER_DATA_LOAD inside the download branch, so when the starter zip was already cached on disk the container would log "custom starter already downloaded" and boot without applying the starter. Move the export to run whenever the cached file exists and is non-empty, and quote paths to satisfy shellcheck. Fixes #35788 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
Contributor
|
Claude finished @wezell's task in 50s —— View job Rollback Safety Analysis
Verdict: ✅ Safe To RollbackFiles changed (1):
Category review:
Why it is safe: The change is confined to a container startup shell script that decides whether to set Label |
Per review feedback on PR #35789: - Switch the cache-presence check from -f to -s so a stale zero-byte file triggers a re-download instead of silently skipping both the download and the DOT_STARTER_DATA_LOAD export. - Quote the remaining path expansions in the file so the shellcheck claim in the PR description holds end-to-end. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
40-custom-starter-zip.shonly exportedDOT_STARTER_DATA_LOADinside the download branch, so a cached starter zip was never applied on restart.Fixes #35788
Test plan
CUSTOM_STARTER_URLset → fresh download, starter installed.DOT_STARTER_DATA_LOADexported).🤖 Generated with Claude Code