Features/feat mypage change throttling - #4
Merged
Conversation
dotani1111
force-pushed
the
features/feat_mypage_change_throttling
branch
2 times, most recently
from
June 2, 2023 14:35
a3fa51d to
b808c96
Compare
dotani1111
force-pushed
the
features/feat_mypage_change_throttling
branch
from
June 2, 2023 14:52
b808c96 to
2dc33fc
Compare
dotani1111
force-pushed
the
features/feat_mypage_change_throttling
branch
from
June 5, 2023 04:16
92d33d8 to
6d0df3d
Compare
dotani1111
added a commit
that referenced
this pull request
May 19, 2026
CodeRabbit review (#4, #9, #10) の指摘に対応する. - admin/Content/layout.twig: codePreview モーダルの「ブロック編集」リンクは `onclick` 属性を直接 replace していたため, 2 回目以降のオープンでは前回 置換済みの ID で固定化されていた. 初回読み取った値を `dataset.onclickTemplate` に退避し, 毎回そこから組み立て直すよう変更. - admin/Store/plugin_table_official.twig: メンテナンスモード解除 fetch の `.then()` が `res.ok` を見ておらず, 解除失敗時にも「削除が完了しました。」 と誤表示していた. `res.ok` が false なら `throw` し外側 `.catch` で 失敗メッセージを出すよう統一. - default/Shopping/index.twig: 顧客情報更新の `toggleDisplay` 3 件が `fetch().finally()` の外にあり, リクエスト発火直後に同期実行されて しまっていた. 成功時のみ表示モードへ遷移するよう `.then()` の `data.status == 'OK'` 分岐内に移動. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
dotani1111
pushed a commit
that referenced
this pull request
Jul 13, 2026
nanasess のレビュー指摘8件に対応。 - GA無条件ロード(OFF時)/同意撤回の非即時/GA越境移転/同意ログの個人データ該当を 制限事項としてコード・ひな型に明記 (#1-#4) - 更新APIの consent_status を all() で受け、配列など非スカラー入力でも BadRequestException でなくクリーンな 400 JSON へ落ちるよう堅牢化 (#6) - source / previous_status を getConsentStatus() と同じ allowlist 方式で正規化 (#5) - 更新APIのルート path を /cookie-consent/update に統一（表示系とハイフンで揃える。 ルート名は不変、JS フォールバック・E2E の直叩きも追従）(#7) - 拒否ボタンをグレー塗りにし同意ボタンと視覚的重みを対等化 (#8, EDPB 03/2022) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
方針(Policy)
実装に関する補足(Appendix)
テスト（Test)
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目