Skip to content

Right path for .md files - #41

Merged
arhimede merged 2 commits into
developfrom
issue-39
Jul 30, 2026
Merged

Right path for .md files#41
arhimede merged 2 commits into
developfrom
issue-39

Conversation

@OStefan2001

Copy link
Copy Markdown
Collaborator

No description provided.

@OStefan2001
OStefan2001 requested a review from arhimede July 30, 2026 10:57
@OStefan2001 OStefan2001 linked an issue Jul 30, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 2.63158% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.08%. Comparing base (e8f5f4a) to head (34a673c).

Files with missing lines Patch % Lines
src/App/src/Handler/GetMarkdownArticleHandler.php 0.00% 30 Missing ⚠️
...p/src/Factory/GetMarkdownArticleHandlerFactory.php 0.00% 6 Missing ⚠️
src/App/src/RoutesDelegator.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #41      +/-   ##
=============================================
- Coverage      18.67%   18.08%   -0.59%     
- Complexity       227      239      +12     
=============================================
  Files             51       53       +2     
  Lines            996     1034      +38     
=============================================
+ Hits             186      187       +1     
- Misses           810      847      +37     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arhimede arhimede left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you moved those files to public direclty

@OStefan2001

Copy link
Copy Markdown
Collaborator Author

I thought it doesn't matter where are placed as long follow the recommended structure

@arhimede

Copy link
Copy Markdown
Member

I thought it doesn't matter where are placed as long follow the recommended structure

Yeah, but not directly in /public
let's create a folder/public/md-articles/ and have them all there

@OStefan2001
OStefan2001 requested a review from arhimede July 30, 2026 16:25
@OStefan2001 OStefan2001 linked an issue Jul 30, 2026 that may be closed by this pull request
@arhimede
arhimede merged commit bff550e into develop Jul 30, 2026
14 of 16 checks passed
@OStefan2001 OStefan2001 removed a link to an issue Jul 30, 2026
@OStefan2001 OStefan2001 mentioned this pull request Jul 31, 2026
@alexmerlin
alexmerlin deleted the issue-39 branch August 2, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

alternate link for md file

2 participants