Skip to content

Issue 49 - #58

Merged
alexmerlin merged 11 commits into
developfrom
issue-49
Aug 3, 2026
Merged

Issue 49#58
alexmerlin merged 11 commits into
developfrom
issue-49

Conversation

@OStefan2001

Copy link
Copy Markdown
Collaborator

No description provided.

@alexmerlin alexmerlin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two solutions here:

  • use https://github.com/dotkernel/dot-response-header
  • rename PoweredByMiddleware to CustomHeaderMiddleware which reads a config with custom headers to be set with each request - today we need only X-Powered-By, but tomorrow we might need another header; we don't want to add another AnotherHeaderMiddleware

@OStefan2001
OStefan2001 requested a review from alexmerlin August 3, 2026 10:58
@OStefan2001 OStefan2001 linked an issue Aug 3, 2026 that may be closed by this pull request
Comment thread LICENSE
@alexmerlin

Copy link
Copy Markdown
Member

@OStefan2001 I fixed the CI issues in #60.
Please update your branch and fix the conflict caused by my fix.

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.08%. Comparing base (16ae433) to head (13727ee).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #58   +/-   ##
==========================================
  Coverage      18.08%   18.08%           
  Complexity       239      239           
==========================================
  Files             53       53           
  Lines           1034     1034           
==========================================
  Hits             187      187           
  Misses           847      847           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arhimede

arhimede commented Aug 3, 2026

Copy link
Copy Markdown
Member

now fix the conflicts, carefully :-)

@OStefan2001
OStefan2001 requested a review from alexmerlin August 3, 2026 13:32
@alexmerlin
alexmerlin merged commit 6ddb395 into develop Aug 3, 2026
16 checks passed
@alexmerlin
alexmerlin deleted the issue-49 branch August 3, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unused variable siteName

3 participants