Use SearchValues for qualified-name separator scans#712
Merged
tannergooding merged 1 commit intoJul 13, 2026
Merged
Conversation
Replace the paired `IndexOf("::")` + `IndexOf('.')` (and `LastIndexOf`
equivalents) separator scans with a single cached `SearchValues<char>`
pass over `{ ':', '.' }`.
In a qualified name a `:` only ever appears as part of a `::` pair, so
scanning for the single characters `:` and `.` is equivalent to scanning
for the `::` and `.` separators, while collapsing two passes into one and
letting the shared `SearchValues` instance be created once.
Converted sites:
- `QualifiedNameComparer.GetHashCode` (`IndexOfAny`)
- The three `LogPotentialTypedefRemappings` diagnostic blocks in
`PInvokeGenerator.cs` (`LastIndexOfAny`)
Single-character scans (e.g. `IndexOf('*')`, `Split('\n')`, `Split(["::"])`
on a substring) are left as-is since `SearchValues<char>` offers no benefit.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the paired
IndexOf("::")+IndexOf('.')(andLastIndexOfequivalents) separator scans with a single cachedSearchValues<char>pass over{ ':', '.' }.In a qualified name a
:only ever appears as part of a::pair, so scanning for the single characters:and.is equivalent to scanning for the::and.separators -- this collapses two passes into one and lets the sharedSearchValuesinstance be created once. The matched-char check (:-> separator length2, else1) preserves the original separator length, soGetHashCodestays consistent withEquals.Converted sites:
QualifiedNameComparer.GetHashCode(IndexOfAny)LogPotentialTypedefRemappingsdiagnostic blocks inPInvokeGenerator.cs(LastIndexOfAny)Single-character scans (e.g.
IndexOf('*'),Split('\n'),Split(["::"])on a substring) are intentionally left as-is sinceSearchValues<char>offers no benefit there.This is behavior-preserving: generator output and comparer results are unchanged. Verified with a
0warning/0error Release build and the full golden test suite (3708passed,0failed); no test expectations were touched.