Harden generator against malformed macro and uuid inputs#720
Merged
tannergooding merged 2 commits intoJul 13, 2026
Merged
Conversation
Guard against empty token arrays in VisitMacroDefinitionRecord and a missing quoted string in the uuid attribute text, and fix the swapped int32-range comments in VisitIntegerLiteral. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…in binary operators The BinaryOperator branch in VisitCharacterLiteral passed the always-null implicitCastExpr from the sibling ImplicitCastExpr branch instead of binaryOperator. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a small set of verified latent robustness/correctness gaps in the managed generator. All are behavior-preserving for valid input.
VisitMacroDefinitionRecorddereferencedtokens[0]before any length check, throwingIndexOutOfRangeExceptionfor macros with an empty extent (e.g. command-line/builtin macros). Now returns gracefully whentokens.Length == 0.TryGetUuidindexed[1]on the split result with no bounds check, crashing before the existingGuid.TryParsefallback could run when the attribute source has no double-quoted string. Now emits aWarningdiagnostic and returnsfalse.VisitIntegerLiteral-- comment-only; the two comments were on the wrong branches.GetRemappedTypeName-- inVisitCharacterLiteral, theBinaryOperatorbranch passed the always-nullimplicitCastExpr(from the siblingImplicitCastExprbranch) instead ofbinaryOperator.Build is
0 warnings / 0 errors; all 3708 generator unit tests pass with byte-identical golden output. No regression tests added -- the unit-test project is purely golden-file (inputContents->expectedOutputContents) and these triggering inputs aren't reproducible through C fixtures.Note
This PR body was drafted by Copilot.