Fix zero-length bitfield handling in the P/Invoke generator#817
Merged
tannergooding merged 2 commits intoJul 17, 2026
Merged
Conversation
A zero-length bitfield (`int : 0;`) is a layout-only marker that names no storage and forces the next bitfield into a fresh storage unit. The generator previously ran it through the normal bitfield path, emitting a bogus 0-length region and packing the following bitfield into the same backing field. Skip it via FieldDecl.IsZeroLengthBitField and reset the run so the next bitfield gets a new storage unit. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…oding-v22-zero-length-bitfield
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A zero-length bitfield (
int : 0;) is a layout-only marker: it names no storage and forces the next bitfield into a fresh storage unit. The generator previously ran it through the normal bitfield path, which emitted a bogus 0-length region and packed the following bitfield into the same backing field.GetBitfieldDescsand theVisitRecordDeclemit loop now skip zero-length bitfields viaFieldDecl.IsZeroLengthBitFieldand reset the running size/bit counters, so the next bitfield lands in a new storage unit.Adds
ZeroLengthBitfieldTest(withGenerateNativeBitfieldAttribute) coveringo0_b0_1->_bitfield1ando4_b0_1->_bitfield2across a: 0boundary. Full generator baseline suite green (4085), 0 warnings.Note
Authored with Copilot.