Document Telephony status enum values - #454
Merged
Merged
Conversation
Refs #230 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 14, 2026 15:32
jonathanpeppers
enabled auto-merge (squash)
August 14, 2026 15:32
There was a problem hiding this comment.
Pull request overview
This PR updates the generated XML documentation for two Android.Telephony enum types by replacing To be added. placeholders with Android TelephonyManager-based descriptions, improving API reference quality in this slice of the Telephony namespace.
Changes:
- Documented
CarrierRestrictionStatusenum type and member values by replacing placeholder summaries. - Documented
CallComposerStatusenum type and member values by replacing placeholder summaries.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/xml/Android.Telephony/CarrierRestrictionStatus.xml | Replaces placeholder enum/member summaries with carrier restriction status descriptions. |
| docs/xml/Android.Telephony/CallComposerStatus.xml | Replaces placeholder enum/member summaries with call composer status descriptions. |
Suppressed comments (2)
docs/xml/Android.Telephony/CallComposerStatus.xml:70
- This summary is not a complete sentence (missing a verb/article), which makes the generated docs read awkwardly.
<summary>Call composer status OFF from user setting.</summary>
docs/xml/Android.Telephony/CallComposerStatus.xml:98
- This summary is not a complete sentence (missing a verb/article), which makes the generated docs read awkwardly.
<summary>Call composer status ON from user setting.</summary>
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #230 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@dalexsoto review |
dalexsoto
approved these changes
Aug 14, 2026
dalexsoto
left a comment
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The Telephony status enum documentation matches the managed members and source values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CallComposerStatusandCarrierRestrictionStatuswith AndroidTelephonyManagerconstant descriptions.Android.Telephonyplaceholders are intentionally outside this narrow slice.Sources
TelephonyManagerreference:CALL_COMPOSER_STATUS_*andCARRIER_RESTRICTION_STATUS_*constants.Validation
git diff --check.To be addedplaceholders and retain CRLF line endings.Refs #230