Document Java time chrono era values - #486
Merged
jonathanpeppers merged 2 commits intoAug 15, 2026
Merged
Conversation
Refs #257 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 14, 2026 21:01
jonathanpeppers
enabled auto-merge (squash)
August 14, 2026 21:01
There was a problem hiding this comment.
Pull request overview
This PR fills in XML documentation placeholders in the Java.Time.Chrono namespace by documenting the Android-exposed era singleton properties for IsoEra, MinguoEra, ThaiBuddhistEra, and HijrahEra, including their era names and numeric getValue() mappings.
Changes:
- Documented
IsoEra.BCE(0) andIsoEra.CE(1) with summaries, values, remarks, and reference links. - Documented
MinguoEra.BEFORE_ROC(0) andMinguoEra.ROC(1) with summaries, values, remarks, and reference links. - Documented
ThaiBuddhistEra.BEFORE_BE(0) andThaiBuddhistEra.BE(1), plusHijrahEra.AH(1), with summaries, values, remarks, and reference links (including AOSP attribution text).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/xml/Java.Time.Chrono/IsoEra.xml | Replaces placeholders with era constant docs for BCE/CE, including numeric values and Android reference links. |
| docs/xml/Java.Time.Chrono/MinguoEra.xml | Replaces placeholders with docs for BEFORE_ROC/ROC, including numeric values and Android reference links. |
| docs/xml/Java.Time.Chrono/ThaiBuddhistEra.xml | Replaces placeholders with docs for BEFORE_BE/BE, including numeric values and Android reference links. |
| docs/xml/Java.Time.Chrono/HijrahEra.xml | Replaces placeholders with docs for AH, including numeric value and Android reference link. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #257 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and removed request for
dalexsoto
August 14, 2026 21:13
Member
Author
|
@dalexsoto review |
dalexsoto
approved these changes
Aug 15, 2026
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The documented API behavior matches the current contracts; no blocking issues found.
jonathanpeppers
deleted the
jonathanpeppers-document-java-time-chrono-05d
branch
August 15, 2026 02:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #257
Documents all seven Android-bound enum constants in Java.Time.Chrono.IsoEra, MinguoEra, ThaiBuddhistEra, and HijrahEra with their names and numeric values.
Sources
Validation