Skip to content

Document Java time chrono era values - #486

Merged
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-document-java-time-chrono-05d
Aug 15, 2026
Merged

Document Java time chrono era values#486
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-document-java-time-chrono-05d

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Refs #257

Documents all seven Android-bound enum constants in Java.Time.Chrono.IsoEra, MinguoEra, ThaiBuddhistEra, and HijrahEra with their names and numeric values.

Sources

Validation

  • Parsed all four changed XML files.
  • Confirmed CRLF line endings in all changed files.
  • Ran git diff --check.
  • Scoped Java.Time.Chrono placeholder count is 349 (seven documented members; remaining namespace gaps are intentionally out of scope).

Refs #257

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fills in XML documentation placeholders in the Java.Time.Chrono namespace by documenting the Android-exposed era singleton properties for IsoEra, MinguoEra, ThaiBuddhistEra, and HijrahEra, including their era names and numeric getValue() mappings.

Changes:

  • Documented IsoEra.BCE (0) and IsoEra.CE (1) with summaries, values, remarks, and reference links.
  • Documented MinguoEra.BEFORE_ROC (0) and MinguoEra.ROC (1) with summaries, values, remarks, and reference links.
  • Documented ThaiBuddhistEra.BEFORE_BE (0) and ThaiBuddhistEra.BE (1), plus HijrahEra.AH (1), with summaries, values, remarks, and reference links (including AOSP attribution text).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
docs/xml/Java.Time.Chrono/IsoEra.xml Replaces placeholders with era constant docs for BCE/CE, including numeric values and Android reference links.
docs/xml/Java.Time.Chrono/MinguoEra.xml Replaces placeholders with docs for BEFORE_ROC/ROC, including numeric values and Android reference links.
docs/xml/Java.Time.Chrono/ThaiBuddhistEra.xml Replaces placeholders with docs for BEFORE_BE/BE, including numeric values and Android reference links.
docs/xml/Java.Time.Chrono/HijrahEra.xml Replaces placeholders with docs for AH, including numeric value and Android reference link.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Refs #257

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers
jonathanpeppers requested review from dalexsoto and removed request for dalexsoto August 14, 2026 21:13
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documented API behavior matches the current contracts; no blocking issues found.

@jonathanpeppers
jonathanpeppers merged commit 58a562c into main Aug 15, 2026
3 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-document-java-time-chrono-05d branch August 15, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants