Document Photo Picker parcelable APIs - #629
Merged
jonathanpeppers merged 2 commits intoAug 18, 2026
Merged
Conversation
Refs #215 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates XML documentation for Android.Widget.PhotoPicker.EmbeddedPhotoPickerFeatureInfo to better cover its Parcelable-related members, aligning the namespace’s docs with the goals in #215 by replacing/augmenting placeholder-style content with source-backed remarks and clearer member summaries.
Changes:
- Added
<remarks>sections with external reference links and AOSP/CC BY attribution forCREATOR,DescribeContents(), andWriteToParcel(...). - Refined
DescribeContents()documentation to reflect the implementation returning no special objects (0). - Updated
WriteToParcel(...)summary to be more specific to the class’s configured features.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #215 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and removed request for
dalexsoto
August 17, 2026 02:48
Member
Author
|
@dalexsoto review |
dalexsoto
approved these changes
Aug 18, 2026
dalexsoto
left a comment
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The Photo Picker parcelable contracts, API metadata, links, and generated documentation are correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #215
Sources
Validation
docs/xml/Android.Widget.PhotoPicker/EmbeddedPhotoPickerFeatureInfo.xmlwithSystem.Xml.XmlDocument.git diff --check.